From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Huang <wei@redhat.com>
Subject: Re: [PATCH V4 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and
 SVM
Date: Wed, 10 Jun 2015 11:43:20 -0500
Message-ID: <55786928.1000909@redhat.com>
References: <1433481616-24884-1-git-send-email-wei@redhat.com> <1433481616-24884-3-git-send-email-wei@redhat.com> <20150610101212.GB20384@8bytes.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, gleb@kernel.org,
	rkrcmar@redhat.com
To: Joerg Roedel <joro@8bytes.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57837 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S966337AbbFJQnX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Jun 2015 12:43:23 -0400
In-Reply-To: <20150610101212.GB20384@8bytes.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 06/10/2015 05:12 AM, Joerg Roedel wrote:
> On Fri, Jun 05, 2015 at 01:20:14AM -0400, Wei Huang wrote:
>> +
>> +	struct kvm_pmu_ops *(*get_pmu_ops)(void);
> 
> Can't you just set kvm_pmu_ops in svm.c and vmx.c and save this
> call-back? Besides that the patch looks good.
Hi Joerg,

Thanks for your review. How about setting up kvm_pmu_ops in
.hardware_setup function of VMX and SVM? More specifically:

1) EXPORT_SYMBOL_GPL(kvm_pmu_ops) from pmu.c file;
2) In vmx.c, set "kvm_pmu_ops = &intel_pmu_ops" in hardware_setup();
3) In svm.c, set "kvm_pmu_ops = &amd_pmu_ops" in svm_hardware_setup().

With that, we can get rid of the call-back.

Thanks,
-Wei


> 
> 
> 	Joerg
>