From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: l2c: add options to overwrite prefetching behavior
Date: Wed, 10 Jun 2015 09:57:18 -0700 [thread overview]
Message-ID: <55786C6E.7070204@gmail.com> (raw)
In-Reply-To: <1432941541-18588-1-git-send-email-hauke@hauke-m.de>
On 29/05/15 16:19, Hauke Mehrtens wrote:
> These options make it possible to overwrites the data and instruction
> prefetching behavior of the arm pl310 cache controller.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> changes since
> v3:
> * remove arm prefix
> * improve documentation
> v2: only set prefetch
> v1: set prefetch and aux
> Documentation/devicetree/bindings/arm/l2cc.txt | 5 +++++
> arch/arm/mm/cache-l2x0.c | 20 ++++++++++++++++++++
> 2 files changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> index 0dbabe9..2251dcc 100644
> --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> @@ -67,6 +67,11 @@ Optional properties:
> disable if zero.
> - arm,prefetch-offset : Override prefetch offset value. Valid values are
> 0-7, 15, 23, and 31.
> +- prefetch-data : Data prefetch. Value: <0> (forcibly disable), <1>
> + (forcibly enable), property absent (retain settings set by firmware)
> +- prefetch-instr : Instruction prefetch. Value: <0> (forcibly disable),
> + <1> (forcibly enable), property absent (retain settings set by
> + firmware)
>
> Example:
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index e309c8f..2570f83 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -1199,6 +1199,26 @@ static void __init l2c310_of_parse(const struct device_node *np,
> pr_err("L2C-310 OF arm,prefetch-offset property value is missing\n");
> }
>
> + ret = of_property_read_u32(np, "prefetch-data", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_DATA_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF prefetch-data property value is missing\n");
> + }
> +
> + ret = of_property_read_u32(np, "prefetch-instr", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF prefetch-instr property value is missing\n");
> + }
> +
> l2x0_saved_regs.prefetch_ctrl = prefetch;
> }
>
>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH v4] ARM: l2c: add options to overwrite prefetching behavior
Date: Wed, 10 Jun 2015 09:57:18 -0700 [thread overview]
Message-ID: <55786C6E.7070204@gmail.com> (raw)
In-Reply-To: <1432941541-18588-1-git-send-email-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
On 29/05/15 16:19, Hauke Mehrtens wrote:
> These options make it possible to overwrites the data and instruction
> prefetching behavior of the arm pl310 cache controller.
>
> Signed-off-by: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
Acked-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> changes since
> v3:
> * remove arm prefix
> * improve documentation
> v2: only set prefetch
> v1: set prefetch and aux
> Documentation/devicetree/bindings/arm/l2cc.txt | 5 +++++
> arch/arm/mm/cache-l2x0.c | 20 ++++++++++++++++++++
> 2 files changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> index 0dbabe9..2251dcc 100644
> --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> @@ -67,6 +67,11 @@ Optional properties:
> disable if zero.
> - arm,prefetch-offset : Override prefetch offset value. Valid values are
> 0-7, 15, 23, and 31.
> +- prefetch-data : Data prefetch. Value: <0> (forcibly disable), <1>
> + (forcibly enable), property absent (retain settings set by firmware)
> +- prefetch-instr : Instruction prefetch. Value: <0> (forcibly disable),
> + <1> (forcibly enable), property absent (retain settings set by
> + firmware)
>
> Example:
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index e309c8f..2570f83 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -1199,6 +1199,26 @@ static void __init l2c310_of_parse(const struct device_node *np,
> pr_err("L2C-310 OF arm,prefetch-offset property value is missing\n");
> }
>
> + ret = of_property_read_u32(np, "prefetch-data", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_DATA_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_DATA_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF prefetch-data property value is missing\n");
> + }
> +
> + ret = of_property_read_u32(np, "prefetch-instr", &val);
> + if (ret == 0) {
> + if (val)
> + prefetch |= L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + else
> + prefetch &= ~L310_PREFETCH_CTRL_INSTR_PREFETCH;
> + } else if (ret != -EINVAL) {
> + pr_err("L2C-310 OF prefetch-instr property value is missing\n");
> + }
> +
> l2x0_saved_regs.prefetch_ctrl = prefetch;
> }
>
>
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-10 16:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 23:19 [PATCH v4] ARM: l2c: add options to overwrite prefetching behavior Hauke Mehrtens
2015-05-29 23:19 ` Hauke Mehrtens
2015-06-10 15:21 ` Thomas Petazzoni
2015-06-10 15:21 ` Thomas Petazzoni
2015-06-10 19:26 ` Hauke Mehrtens
2015-06-10 19:26 ` Hauke Mehrtens
2015-06-11 7:26 ` Thomas Petazzoni
2015-06-11 7:26 ` Thomas Petazzoni
2015-06-11 9:24 ` Thomas Petazzoni
2015-06-11 9:24 ` Thomas Petazzoni
2015-06-11 9:34 ` Russell King - ARM Linux
2015-06-11 9:34 ` Russell King - ARM Linux
2015-06-11 9:39 ` Russell King - ARM Linux
2015-06-11 9:39 ` Russell King - ARM Linux
2015-06-11 9:47 ` Thomas Petazzoni
2015-06-11 9:47 ` Thomas Petazzoni
2015-06-10 16:57 ` Florian Fainelli [this message]
2015-06-10 16:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55786C6E.7070204@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.