From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256
Date: Wed, 10 Jun 2015 16:29:16 -0400
Message-ID: <55789E1C.9030504@citrix.com>
References: <1433849019-27452-1-git-send-email-olaf@aepfle.de>
	<1433849019-27452-3-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1433849019-27452-3-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xen.org, George Dunlap <george.dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi Olaf,

On 09/06/2015 07:23, Olaf Hering wrote:
> To match the hypervisor default which was introduced in
> 9da0c5b63933b9912e3903190601661813954d0d, bump the limit.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>   tools/xentrace/analyze.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/analyze.h b/tools/xentrace/analyze.h
> index 40ee551..64b1911 100644
> --- a/tools/xentrace/analyze.h
> +++ b/tools/xentrace/analyze.h
> @@ -16,7 +16,7 @@
>
>   #define TRC_LOST_RECORDS_END    (TRC_GEN + 50)
>
> -#define NR_CPUS 128
> +#define NR_CPUS 256

You are updating NR_CPUS but this is only used for cpumask_t which is 
never used within xenalyze.

Only cpu_mask_t is used and alias to a uint32_t. Or did I miss something?

There is also a variable MAX_CPUS defined to 256. which is used every.

Regards,

-- 
Julien Grall