From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, berto@igalia.com, armbru@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 01/13] qdict: Add qdict_array_entries()
Date: Wed, 10 Jun 2015 14:50:06 -0600 [thread overview]
Message-ID: <5578A2FE.9020108@redhat.com> (raw)
In-Reply-To: <1433944027-28533-2-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On 06/10/2015 07:46 AM, Kevin Wolf wrote:
> This counts the entries in a flattened array in a QDict without
> actually splitting the QDict into a QList.
>
> bdrv_open_image() doesn't take a QList, but rather a QDict and a key
> prefix string, so this is more convenient for block drivers which have a
> dynamically sized list of child nodes (e.g. Quorum) and are to be
> converted to using bdrv_open_image() as the standard interface for
> opening child nodes.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/qapi/qmp/qdict.h | 1 +
> qobject/qdict.c | 78 +++++++++++++++++++++++++++++++++++++++++++++---
> 2 files changed, 75 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-06-10 20:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 13:46 [Qemu-devel] [PATCH v2 00/13] bdrv_reopen() overhaul, part 1 Kevin Wolf
2015-06-10 13:46 ` [Qemu-devel] [PATCH v2 01/13] qdict: Add qdict_array_entries() Kevin Wolf
2015-06-10 20:50 ` Eric Blake [this message]
2015-06-12 14:07 ` Max Reitz
2015-06-10 13:46 ` [Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default() Kevin Wolf
2015-06-10 21:29 ` Eric Blake
2015-06-10 13:46 ` [Qemu-devel] [PATCH v2 03/13] check-qdict: Test cases for new functions Kevin Wolf
2015-06-10 21:34 ` Eric Blake
2015-06-12 14:12 ` Max Reitz
2015-06-10 13:46 ` [Qemu-devel] [PATCH v2 04/13] quorum: Use bdrv_open_image() Kevin Wolf
2015-06-10 13:46 ` [Qemu-devel] [PATCH v2 05/13] vmdk: " Kevin Wolf
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 06/13] block: Use macro for cache option names Kevin Wolf
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common() Kevin Wolf
2015-06-10 21:42 ` Eric Blake
2015-06-12 14:15 ` Max Reitz
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 08/13] block: Move flag inheritance to bdrv_open_inherit() Kevin Wolf
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 09/13] block: Drain requests before swapping nodes in bdrv_swap() Kevin Wolf
2015-06-10 23:17 ` Eric Blake
2015-06-12 14:16 ` Max Reitz
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 10/13] queue.h: Add QLIST_FIX_HEAD_PTR() Kevin Wolf
2015-06-10 23:19 ` Eric Blake
2015-06-12 14:19 ` Max Reitz
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 11/13] block: Add list of children to BlockDriverState Kevin Wolf
2015-06-10 23:26 ` Eric Blake
2015-06-12 14:23 ` Max Reitz
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 12/13] block: Add BlockDriverState.inherits_from Kevin Wolf
2015-06-10 13:47 ` [Qemu-devel] [PATCH v2 13/13] block: Fix reopen flag inheritance Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578A2FE.9020108@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.