From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Matt Ranostay <mranostay@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Daniel Mack <zonque@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] cap11xx: add LED support
Date: Thu, 11 Jun 2015 08:55:36 +0200 [thread overview]
Message-ID: <557930E8.3020408@samsung.com> (raw)
In-Reply-To: <CAKzfze_+XEQB5VTiH6BcyU297OnEWc3JK0m2hLuVsqhykCfPAw@mail.gmail.com>
On 06/11/2015 12:07 AM, Matt Ranostay wrote:
[...]
>>> static const struct cap11xx_hw_model cap11xx_devices[] = {
>>> - [CAP1106] = { .product_id = 0x55, .num_channels = 6 },
>>> - [CAP1126] = { .product_id = 0x53, .num_channels = 6 },
>>> - [CAP1188] = { .product_id = 0x50, .num_channels = 8 },
>>> + [CAP1106] = { .product_id = 0x55, .num_channels = 6, .num_leds = 0
>>> },
>>> + [CAP1126] = { .product_id = 0x53, .num_channels = 6, .num_leds = 2
>>> },
>>> + [CAP1188] = { .product_id = 0x50, .num_channels = 8, .num_leds = 8
>>> },
>>> };
>>
>>
>> The number of LEDs should be determined by the number of DT child nodes
>> representing each LED. Please refer to
>> Documentation/devicetree/bindings/leds/common.txt and other LED
>> subsystem drivers to find out how it should be implemented.
>>
> Ok but this is still needed as a check so you don't "overflow" the
> number the chipset supports, correct?
Right, the above modification is correct then.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-06-11 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 7:08 [PATCH v2] cap11xx: add LED support Matt Ranostay
2015-06-10 8:03 ` Jacek Anaszewski
2015-06-10 22:07 ` Matt Ranostay
2015-06-11 6:55 ` Jacek Anaszewski [this message]
2015-06-11 23:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557930E8.3020408@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.