From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v3][PATCH 02/16] xen/x86/p2m: introduce
	set_identity_p2m_entry
Date: Thu, 11 Jun 2015 17:18:26 +0800
Message-ID: <55795262.809@intel.com>
References: <1433985325-16676-1-git-send-email-tiejun.chen@intel.com>
	<1433985325-16676-3-git-send-email-tiejun.chen@intel.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D126289F5A@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D126289F5A@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Tian, Kevin" <kevin.tian@intel.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "tim@xen.org" <tim@xen.org>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "Zhang, Yang Z" <yang.z.zhang@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, "Ian.Jackson@eu.citrix.com" <Ian.Jackson@eu.citrix.com>, "stefano.stabellini@citrix.com" <stefano.stabellini@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 2015/6/11 17:00, Tian, Kevin wrote:
>> From: Chen, Tiejun
>> Sent: Thursday, June 11, 2015 9:15 AM
>>
>> We will create this sort of identity mapping as follows:
>>
>> If the gfn space is unoccupied, we just set the mapping. If the space
>> is already occupied by 1:1 mappings, do nothing. Failed for any
>> other cases.
>
> "If space is already occupied by desired identity mapping, do nothing.
> Otherwise, failure is returned."

Okay.

>
>>
>> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>, plus one small
> comment as below:
>
>
>> +            printk(XENLOG_G_WARNING
>> +                   "Cannot identity map d%d:%lx, already mapped to %lx.\n",
>> +                   d->domain_id, gfn, mfn_x(mfn));
>
> "Cannot setup identity map, ..., gfn already mapped to..."
>

Fixed.

Thanks
Tiejun