From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Date: Thu, 11 Jun 2015 09:26:04 +0000 Subject: Re: [patch] drm/amdgpu: remove an unnecessary condition Message-Id: <5579542C.1060003@amd.com> List-Id: References: <20150611081924.GA27090@mwanda> In-Reply-To: <20150611081924.GA27090@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dan Carpenter , David Airlie , Alex Deucher Cc: =?windows-1252?Q?Marek_Ol=9A=E1k?= , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, yanyang1 , Ken Wang On 11.06.2015 10:19, Dan Carpenter wrote: > We already checked "if (r)" so there is no need to check again. > > Signed-off-by: Dan Carpenter Hi Dan, thanks for taking a look into this. This patch and the other two you=20 send today are Reviewed-by: Christian K=F6nig That code was branched of from Radeon it is possible that the same=20 changes apply there as well. Since it looks like you created those=20 patches at least partially automatically could you run your tool on the=20 Radeon code once more as well? Thanks in advance, Christian. > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/am= d/amdgpu/amdgpu_kms.c > index 5533434..b7d0425 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > @@ -111,12 +111,9 @@ int amdgpu_driver_load_kms(struct drm_device *dev, u= nsigned long flags) > /* Call ACPI methods: require modeset init > * but failure is not fatal > */ > - if (!r) { > - acpi_status =3D amdgpu_acpi_init(adev); > - if (acpi_status) > - dev_dbg(&dev->pdev->dev, > - "Error during ACPI methods call\n"); > - } > + acpi_status =3D amdgpu_acpi_init(adev); > + if (acpi_status) > + dev_dbg(&dev->pdev->dev, "Error during ACPI methods call\n"); > =20 > if (amdgpu_device_is_px(dev)) { > pm_runtime_use_autosuspend(dev->dev); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Subject: Re: [patch] drm/amdgpu: remove an unnecessary condition Date: Thu, 11 Jun 2015 11:26:04 +0200 Message-ID: <5579542C.1060003@amd.com> References: <20150611081924.GA27090@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0114.outbound.protection.outlook.com [157.56.111.114]) by gabe.freedesktop.org (Postfix) with ESMTP id E56B97A157 for ; Thu, 11 Jun 2015 02:26:12 -0700 (PDT) In-Reply-To: <20150611081924.GA27090@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , David Airlie , Alex Deucher Cc: =?windows-1252?Q?Marek_Ol=9A=E1k?= , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, yanyang1 , Ken Wang List-Id: dri-devel@lists.freedesktop.org T24gMTEuMDYuMjAxNSAxMDoxOSwgRGFuIENhcnBlbnRlciB3cm90ZToKPiBXZSBhbHJlYWR5IGNo ZWNrZWQgImlmIChyKSIgc28gdGhlcmUgaXMgbm8gbmVlZCB0byBjaGVjayBhZ2Fpbi4KPgo+IFNp Z25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KCkhp IERhbiwKCnRoYW5rcyBmb3IgdGFraW5nIGEgbG9vayBpbnRvIHRoaXMuIFRoaXMgcGF0Y2ggYW5k IHRoZSBvdGhlciB0d28geW91IApzZW5kIHRvZGF5IGFyZSBSZXZpZXdlZC1ieTogQ2hyaXN0aWFu IEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgoKVGhhdCBjb2RlIHdhcyBicmFuY2hl ZCBvZiBmcm9tIFJhZGVvbiBpdCBpcyBwb3NzaWJsZSB0aGF0IHRoZSBzYW1lIApjaGFuZ2VzIGFw cGx5IHRoZXJlIGFzIHdlbGwuIFNpbmNlIGl0IGxvb2tzIGxpa2UgeW91IGNyZWF0ZWQgdGhvc2Ug CnBhdGNoZXMgYXQgbGVhc3QgcGFydGlhbGx5IGF1dG9tYXRpY2FsbHkgY291bGQgeW91IHJ1biB5 b3VyIHRvb2wgb24gdGhlIApSYWRlb24gY29kZSBvbmNlIG1vcmUgYXMgd2VsbD8KClRoYW5rcyBp biBhZHZhbmNlLApDaHJpc3RpYW4uCgo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9rbXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9rbXMuYwo+IGluZGV4IDU1MzM0MzQuLmI3ZDA0MjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2ttcy5jCj4gQEAgLTExMSwxMiArMTExLDkgQEAgaW50IGFtZGdwdV9k cml2ZXJfbG9hZF9rbXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgbG9uZyBmbGFn cykKPiAgIAkvKiBDYWxsIEFDUEkgbWV0aG9kczogcmVxdWlyZSBtb2Rlc2V0IGluaXQKPiAgIAkg KiBidXQgZmFpbHVyZSBpcyBub3QgZmF0YWwKPiAgIAkgKi8KPiAtCWlmICghcikgewo+IC0JCWFj cGlfc3RhdHVzID0gYW1kZ3B1X2FjcGlfaW5pdChhZGV2KTsKPiAtCQlpZiAoYWNwaV9zdGF0dXMp Cj4gLQkJZGV2X2RiZygmZGV2LT5wZGV2LT5kZXYsCj4gLQkJCQkiRXJyb3IgZHVyaW5nIEFDUEkg bWV0aG9kcyBjYWxsXG4iKTsKPiAtCX0KPiArCWFjcGlfc3RhdHVzID0gYW1kZ3B1X2FjcGlfaW5p dChhZGV2KTsKPiArCWlmIChhY3BpX3N0YXR1cykKPiArCQlkZXZfZGJnKCZkZXYtPnBkZXYtPmRl diwgIkVycm9yIGR1cmluZyBBQ1BJIG1ldGhvZHMgY2FsbFxuIik7Cj4gICAKPiAgIAlpZiAoYW1k Z3B1X2RldmljZV9pc19weChkZXYpKSB7Cj4gICAJCXBtX3J1bnRpbWVfdXNlX2F1dG9zdXNwZW5k KGRldi0+ZGV2KTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==