From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 11 Jun 2015 12:58:26 +0000 Subject: Re: [PATCH v6 2/2] Renesas Ethernet AVB PTP clock driver Message-Id: <557985F2.9010900@cogentembedded.com> List-Id: References: <2950738.iaDWZVkjG3@wasted.cogentembedded.com> <20150611.001455.377939359927165224.davem@davemloft.net> <20150611.002425.1698330124707614277.davem@davemloft.net> In-Reply-To: <20150611.002425.1698330124707614277.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: netdev@vger.kernel.org, richardcochran@gmail.com, linux-sh@vger.kernel.org, masaru.nagai.vx@renesas.com Hello. On 6/11/2015 10:24 AM, David Miller wrote: >>> Ethernet AVB device includes the gPTP timer, so we can implement a PTP clock >>> driver. We're doing that in a separate file, with the main Ethernet driver >>> calling the PTP driver's [de]initialization and interrupt handler functions. >>> Unfortunately, the clock seems tightly coupled with the AVB-DMAC, so when that >>> one leaves the operation mode, we have to unregister the PTP clock... :-( >>> Based on the original patches by Masaru Nagai. >>> Signed-off-by: Masaru Nagai >>> Signed-off-by: Sergei Shtylyov >> Applied. Thank you! > I had to fix up this patch because: > obj-$(CONFIG_RAVB) += ravb_main.o ravb_ptp.o > Doesn't do what you want it to for the modular case. Oh, crap, I forgot to test the modular build after splitting the driver again into separate files. Sorry about that... :-< > You instead need to say something like: > ravb-objs := ravb_main.o ravb_ptp.o > obj-$(CONFIG_RAVB) += ravb.o > and that's how I fixed up this commit before pushing it out. And the code base I was using as a reference had this issue fixed quite similarly... WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v6 2/2] Renesas Ethernet AVB PTP clock driver Date: Thu, 11 Jun 2015 15:58:26 +0300 Message-ID: <557985F2.9010900@cogentembedded.com> References: <2950738.iaDWZVkjG3@wasted.cogentembedded.com> <20150611.001455.377939359927165224.davem@davemloft.net> <20150611.002425.1698330124707614277.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, richardcochran@gmail.com, linux-sh@vger.kernel.org, masaru.nagai.vx@renesas.com To: David Miller Return-path: In-Reply-To: <20150611.002425.1698330124707614277.davem@davemloft.net> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 6/11/2015 10:24 AM, David Miller wrote: >>> Ethernet AVB device includes the gPTP timer, so we can implement a PTP clock >>> driver. We're doing that in a separate file, with the main Ethernet driver >>> calling the PTP driver's [de]initialization and interrupt handler functions. >>> Unfortunately, the clock seems tightly coupled with the AVB-DMAC, so when that >>> one leaves the operation mode, we have to unregister the PTP clock... :-( >>> Based on the original patches by Masaru Nagai. >>> Signed-off-by: Masaru Nagai >>> Signed-off-by: Sergei Shtylyov >> Applied. Thank you! > I had to fix up this patch because: > obj-$(CONFIG_RAVB) += ravb_main.o ravb_ptp.o > Doesn't do what you want it to for the modular case. Oh, crap, I forgot to test the modular build after splitting the driver again into separate files. Sorry about that... :-< > You instead need to say something like: > ravb-objs := ravb_main.o ravb_ptp.o > obj-$(CONFIG_RAVB) += ravb.o > and that's how I fixed up this commit before pushing it out. And the code base I was using as a reference had this issue fixed quite similarly... WBR, Sergei