All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/video: Set EFI framebuffer to WC by default
Date: Thu, 11 Jun 2015 14:03:37 +0100	[thread overview]
Message-ID: <55798729.20208@citrix.com> (raw)
In-Reply-To: <55799CA20200007800083A81@mail.emea.novell.com>

On 06/11/2015 01:35 PM, Jan Beulich wrote:
>>>> On 11.06.15 at 14:09, <ross.lagerwall@citrix.com> wrote:
>> Set the EFI framebuffer to write-combining by default. This makes
>> booting somewhat faster, but more importantly avoids tripping the
>> watchdog. In particular, before on my test machine, each frame redraw
>> would take around 80ms, which can trip the 5s watchdog when constructing
>> dom0, since it outputs something like 60 lines without processing
>> pending softirqs.
>
> That would need fixing then. What are those 60 lines?

I think it's the lines from "Testing NMI watchdog on all CPUs: ok" to 
"Scrubbing Free RAM".

>
>> Both Linux and FreeBSD map the EFI framebuffer as write-combining by
>> default, so I assume (hope) that this is a safe change to make.
>
> No, an unaware Dom0 OS may not work correctly when the frame
> buffer is WC. It also might come as a surprise to the Dom0 OS that
> there is a WC range in one of the MTRRs where none would be
> expected. Plus - why for EFI only?

Because that's what other OSes did, but if it's not going to work... I 
can send a patch which we're currently using which sticks in a few 
process_pending_softirqs() in strategic places.

-- 
Ross Lagerwall

  reply	other threads:[~2015-06-11 13:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 12:09 [PATCH] xen/video: Set EFI framebuffer to WC by default Ross Lagerwall
2015-06-11 12:35 ` Jan Beulich
2015-06-11 13:03   ` Ross Lagerwall [this message]
2015-06-11 13:38     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55798729.20208@citrix.com \
    --to=ross.lagerwall@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.