All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] x86: Avoid tripping watchdog when constructing dom0
Date: Thu, 11 Jun 2015 14:07:23 +0100	[thread overview]
Message-ID: <5579880B.1080008@citrix.com> (raw)
In-Reply-To: <1434027810-27194-1-git-send-email-ross.lagerwall@citrix.com>

On 11/06/15 14:03, Ross Lagerwall wrote:
> Constructing dom0 may take a few seconds, particularly if the slow VESA
> graphics terminal is used. Process pending softirqs a few times to avoid
> tripping a watchdog with a short timeout.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  xen/arch/x86/domain_build.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c
> index 03e4bfe..98d27f2 100644
> --- a/xen/arch/x86/domain_build.c
> +++ b/xen/arch/x86/domain_build.c
> @@ -930,6 +930,8 @@ int __init construct_dom0(
>      BUG_ON(d->vcpu[0] == NULL);
>      BUG_ON(v->is_initialised);
>  
> +    process_pending_softirqs();
> +
>      printk("*** LOADING DOMAIN 0 ***\n");
>  
>      d->max_pages = ~0U;
> @@ -946,6 +948,8 @@ int __init construct_dom0(
>      if ( (rc = elf_xen_parse(&elf, &parms)) != 0 )
>          goto out;
>  
> +    process_pending_softirqs();
> +
>      /* compatibility check */
>      compatible = 0;
>      compat32   = 0;
> @@ -1167,6 +1171,8 @@ int __init construct_dom0(
>             _p(v_start), _p(v_end));
>      printk(" ENTRY ADDRESS: %p\n", _p(parms.virt_entry));
>  
> +    process_pending_softirqs();
> +
>      mpt_alloc = (vpt_start - v_start) + pfn_to_paddr(alloc_spfn);
>      if ( vinitrd_start )
>          mpt_alloc -= PAGE_ALIGN(initrd_len);

  reply	other threads:[~2015-06-11 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 13:03 [PATCH] x86: Avoid tripping watchdog when constructing dom0 Ross Lagerwall
2015-06-11 13:07 ` Andrew Cooper [this message]
2015-06-11 14:22 ` Jan Beulich
2015-06-11 15:39   ` Ross Lagerwall
2015-06-11 16:07     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5579880B.1080008@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.