From: Julien Grall <julien.grall@citrix.com>
To: Wei Wang <wei.w.wang@intel.com>,
xen-devel@lists.xen.org, jbeulich@suse.com
Cc: andrew.cooper3@citrix.com
Subject: Re: [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c
Date: Thu, 11 Jun 2015 10:10:53 -0400 [thread overview]
Message-ID: <557996ED.9060806@citrix.com> (raw)
In-Reply-To: <1434011460-18222-1-git-send-email-wei.w.wang@intel.com>
Hi,
On 11/06/2015 04:31, Wei Wang wrote:
> - list_for_each(pos, &cpufreq_governor_list)
> + if (policy->policy)
What if another cpufreq decides to use policy->policy?
> + gov_num = INTEL_PSTATE_INTERNAL_GOV_NUM;
Why not using cpufreq_governor_list?
> + else
> + {
> + list_for_each(pos, &cpufreq_governor_list)
> gov_num++;
The indentation looks wrong to me.
--
Julien Grall
next prev parent reply other threads:[~2015-06-11 14:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:31 [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c Wei Wang
2015-06-11 14:10 ` Julien Grall [this message]
2015-06-12 3:03 ` Wang, Wei W
2015-06-12 8:39 ` Jan Beulich
2015-06-12 11:13 ` Julien Grall
2015-06-15 0:30 ` Wang, Wei W
2015-06-15 9:15 ` Jan Beulich
2015-06-15 12:28 ` Wang, Wei W
2015-06-15 12:36 ` Jan Beulich
2015-06-15 14:11 ` Wang, Wei W
2015-06-16 7:09 ` Wang, Wei W
2015-06-16 7:53 ` Jan Beulich
2015-06-17 5:01 ` Wang, Wei W
2015-06-23 1:40 ` Wang, Wei W
2015-06-23 8:45 ` Wang, Wei W
2015-06-23 8:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557996ED.9060806@citrix.com \
--to=julien.grall@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wei.w.wang@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.