From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v3 10/11] x86/intel_pstate: support the use
 of intel_pstate in pmstat.c
Date: Thu, 11 Jun 2015 10:10:53 -0400
Message-ID: <557996ED.9060806@citrix.com>
References: <1434011460-18222-1-git-send-email-wei.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434011460-18222-1-git-send-email-wei.w.wang@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Wang <wei.w.wang@intel.com>, xen-devel@lists.xen.org, jbeulich@suse.com
Cc: andrew.cooper3@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi,

On 11/06/2015 04:31, Wei Wang wrote:
> -    list_for_each(pos, &cpufreq_governor_list)
> +    if (policy->policy)

What if another cpufreq decides to use policy->policy?

> +        gov_num = INTEL_PSTATE_INTERNAL_GOV_NUM;

Why not using cpufreq_governor_list?

> +    else
> +    {
> +        list_for_each(pos, &cpufreq_governor_list)
>           gov_num++;

The indentation looks wrong to me.

-- 
Julien Grall