From: George Dunlap <george.dunlap@eu.citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>, Tim Deegan <tim@xen.org>,
Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen: cpupool: fix shutdown with cpupools with different schedulers
Date: Thu, 11 Jun 2015 15:24:51 +0100 [thread overview]
Message-ID: <55799A33.1070608@eu.citrix.com> (raw)
In-Reply-To: <20150611123151.6295.14758.stgit@Solace.station>
On 06/11/2015 01:31 PM, Dario Faggioli wrote:
> trying to shutdown the host when a cpupool exists, has
> pCPUs, and has a scheduler different than the Xen's default
> one, produces this:
>
> root@Zhaman:~# xl cpupool-cpu-remove Pool-0 8
> root@Zhaman:~# xl cpupool-create name=\"Pool-1\" sched=\"credit2\"
> Using config file "command line"
> cpupool name: Pool-1
> scheduler: credit2
> number of cpus: 0
> root@Zhaman:~# xl cpupool-cpu-add Pool-1 8
> root@Zhaman:~# shutdown -h now
>
> (XEN) ----[ Xen-4.6-unstable x86_64 debug=y Not tainted ]----
> (XEN) CPU: 0
> (XEN) RIP: e008:[<ffff82d080133bdf>] kill_timer+0x56/0x298
> (XEN) RFLAGS: 0000000000010002 CONTEXT: hypervisor
> ... ... ...
> (XEN) Xen call trace:
> (XEN) [<ffff82d080133bdf>] kill_timer+0x56/0x298
> (XEN) [<ffff82d08012233f>] csched_free_pdata+0x9b/0xcf
> (XEN) [<ffff82d08012c30c>] cpu_schedule_callback+0x64/0x8b
> (XEN) [<ffff82d08011bc7a>] notifier_call_chain+0x67/0x87
> (XEN) [<ffff82d08010153e>] cpu_down+0xd9/0x12c
> (XEN) [<ffff82d080101744>] disable_nonboot_cpus+0x93/0x138
> (XEN) [<ffff82d0801aa6e7>] enter_state_helper+0xbd/0x365
> (XEN) [<ffff82d0801061e5>] continue_hypercall_tasklet_handler+0x4a/0xb1
> (XEN) [<ffff82d080132387>] do_tasklet_work+0x78/0xab
> (XEN) [<ffff82d0801326bd>] do_tasklet+0x5e/0x8a
> (XEN) [<ffff82d0801646d2>] idle_loop+0x56/0x6b
> ... ... ...
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) FATAL PAGE FAULT
> (XEN) [error_code=0000]
> (XEN) Faulting linear address: 0000000000000041
> (XEN) ****************************************
>
> The fix is, when tearing down a pCPU, call the free_pdata()
> hook from the scheduler of the cpupool the pCPU belongs to,
> not always the one from the default scheduler.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
prev parent reply other threads:[~2015-06-11 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 12:31 [PATCH] xen: cpupool: fix shutdown with cpupools with different schedulers Dario Faggioli
2015-06-11 12:46 ` Juergen Gross
2015-06-11 14:24 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55799A33.1070608@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.