From: George Dunlap <george.dunlap@eu.citrix.com>
To: Julien Grall <julien.grall@citrix.com>, Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256
Date: Thu, 11 Jun 2015 15:35:38 +0100 [thread overview]
Message-ID: <55799CBA.3020005@eu.citrix.com> (raw)
In-Reply-To: <55796B1C.9020309@citrix.com>
On 06/11/2015 12:03 PM, Julien Grall wrote:
>
>
> On 11/06/2015 02:12, Olaf Hering wrote:
>> On Wed, Jun 10, Julien Grall wrote:
>>
>>> There is also a variable MAX_CPUS defined to 256. which is used every.
>>
>> You are right, while forwarding an old patch (from memory) I changed the
>> wrong place. MAX_CPUS is already at 256 so no change is strictly
>> neccessary.
>>
>> I suggest to drop that patch from this series while applying.
>> Thanks for the review.
>
> I would suggest some refactoring to remove NR_CPUS and associated code
> in order to avoid mis-usage later.
>
> Also, cpu_mask_t is a uint32_t, is it intentional?
When xenalyze was originally written back in 2006, I think that's
probably how it was defined in Xen. I just haven't used it on a system
with more than 32 cpus. :-)
That certainly should be addressed at some point. I'd be in favor of
checking this in and fixing it up later; or, for the time being, just
disabling the skew detection functionality (which is the only place that
uses it, AFAICT).
-George
next prev parent reply other threads:[~2015-06-11 14:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 11:23 [PATCH v5 0/8] add xenalyze to staging Olaf Hering
2015-06-09 11:23 ` [PATCH v5 1/8] xenalyze: add to tools/xentrace/ Olaf Hering
2015-06-11 15:23 ` George Dunlap
2015-06-11 16:04 ` Olaf Hering
2015-06-09 11:23 ` [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256 Olaf Hering
2015-06-10 20:29 ` Julien Grall
2015-06-11 6:12 ` Olaf Hering
2015-06-11 11:03 ` Julien Grall
2015-06-11 14:35 ` George Dunlap [this message]
2015-06-15 16:14 ` Olaf Hering
2015-06-15 17:19 ` Andrew Cooper
2015-06-15 17:58 ` Olaf Hering
2015-06-16 8:33 ` Ian Campbell
2015-06-16 8:35 ` Olaf Hering
2015-06-09 11:23 ` [PATCH v5 3/8] xenalyze: print newline after unknown hvm events Olaf Hering
2015-06-09 11:23 ` [PATCH v5 4/8] xenalyze: include odd mmio states in default output Olaf Hering
2015-06-09 11:23 ` [PATCH v5 5/8] xenalyze: handle TRC_TRACE_WRAP_BUFFER Olaf Hering
2015-06-09 11:23 ` [PATCH v5 6/8] xenalyze: handle more events in sched_process Olaf Hering
2015-06-09 11:23 ` [PATCH v5 7/8] xenalyze: remove trailing whitespaces Olaf Hering
2015-06-09 11:23 ` [PATCH v5 8/8] xenalyze: remove argp_program_version Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55799CBA.3020005@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.