All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Hannes Reinecke <hare@suse.de>, Andy Grover <agrover@redhat.com>,
	Nic Bellinger <nab@daterainc.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/2] target: 64-bit LUN support
Date: Thu, 11 Jun 2015 07:38:04 -0700	[thread overview]
Message-ID: <55799D4C.6070505@sandisk.com> (raw)
In-Reply-To: <55792317.5020500@suse.de>

On 06/10/15 22:56, Hannes Reinecke wrote:
> Actually, I've been thinking about this. Currently I'm not sure if
> we should fully embrace this route; after all, 'scsilun_to_int' is
> meant to be a conversion from the (abstract) LUN number into our
> internal representation.
> And as it's internal we're free to use whatever we like.
>
> Where we need to fix up things is in reporting; whenever we display
> LUN numbers to userspace (printk or sysfs-wise) we probably should
> use the appropriate format.
>
> I'll see if I can whip up a printk format for this.
> Never liked the '%llu' format for LUNs anyway.

Hello Hannes,

Making how LUNs are displayed dependent on the LUN addressing method 
sounds like a good idea to me. One step further would be to ensure that 
the format in which LUNs are entered through configfs matches the format 
used to display LUNs. This may require to add an additional 
configuration parameter in configfs for the LUN addressing format. E.g. 
for users who connect an AIX initiator system to LIO it would be much 
more convenient to use LUN numbers like 1, 2, 3 instead of the raw LUN 
numbers 256, 512, 768.

Thanks,

Bart.

      reply	other threads:[~2015-06-11 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  6:41 [PATCH 0/2] target: 64-bit LUN support Hannes Reinecke
2015-06-10  6:41 ` [PATCH 1/2] target: use 64-bit LUNs Hannes Reinecke
2015-06-10  6:41 ` [PATCH 2/2] target: Remove TARGET_MAX_LUNS_PER_TRANSPORT Hannes Reinecke
2015-06-10  8:07 ` [PATCH 0/2] target: 64-bit LUN support Nicholas A. Bellinger
2015-06-10 16:45 ` Andy Grover
2015-06-11  5:56   ` Hannes Reinecke
2015-06-11 14:38     ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55799D4C.6070505@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=agrover@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@daterainc.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.