From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfsprogs for-next build error on Debian Wheezy / amd64
Date: Thu, 11 Jun 2015 11:14:27 -0500 [thread overview]
Message-ID: <5579B3E3.2080400@sandeen.net> (raw)
In-Reply-To: <20150611160335.GA28312@infradead.org>
On 6/11/15 11:03 AM, Christoph Hellwig wrote:
> On Wed, Jun 10, 2015 at 07:19:52PM +1000, Dave Chinner wrote:
>> Actually, I think that platform_defs.h needs to be symlinked into
>> include/xfs. that was the intent, but I bet I missed it because
>> the build wasn't failing and so I didn't notice that I'd failed to
>> put it into the the include/Makefile rule for installed headers.
>>
>> Yeah, there we are - the install-dev rule has a specific install
>> rule for platform_defs.h as well, so it was being included in the
>> package builds correctly (i.e. installed in /usr/include/xfs)
>> without being mentioned in the HFILES definition that defines header
>> files to be packaged for /usr/include/xfs....
>>
>> Patch below (which uncovers another issue to do with include files
>> on the distclean side, but is not fatal and I'll fix tomorrow).
>
> This works fine for me.
>
> Btw, we really shouldn't be installing generated files, that's a major
> PITA for multiarch setups. I'll see how much of the autoconf magic
> we even need here.
FWIW, we do a crazy thing in RPM land ...
# cat /usr/include/xfs/platform_defs.h
/* This file is here to prevent a file conflict on multiarch systems. A
* conflict will occur because platform_defs.h has arch-specific definitions.
*
* DO NOT INCLUDE THE NEW FILE DIRECTLY -- ALWAYS INCLUDE THIS ONE INSTEAD. */
#if defined(__i386__)
#include "platform_defs-i386.h"
#elif defined(__x86_64__)
#include "platform_defs-x86_64.h"
#elif defined(__powerpc64__)
#include "platform_defs-ppc64.h"
... etc ...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-06-11 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 7:06 xfsprogs for-next build error on Debian Wheezy / amd64 Christoph Hellwig
2015-06-10 8:19 ` Dave Chinner
2015-06-10 8:24 ` Christoph Hellwig
2015-06-10 8:29 ` Christoph Hellwig
2015-06-10 8:34 ` Dave Chinner
2015-06-10 8:40 ` Christoph Hellwig
2015-06-10 9:19 ` Dave Chinner
2015-06-11 16:03 ` Christoph Hellwig
2015-06-11 16:14 ` Eric Sandeen [this message]
2015-06-11 17:24 ` Christoph Hellwig
2015-06-17 10:31 ` Christoph Hellwig
2015-06-10 8:44 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5579B3E3.2080400@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.