All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, arei.gonglei@huawei.com,
	mrhines@us.ibm.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 04/12] rdma typos
Date: Thu, 11 Jun 2015 12:56:06 -0500	[thread overview]
Message-ID: <5579CBB6.8080604@linux.vnet.ibm.com> (raw)
In-Reply-To: <1434043048-4444-5-git-send-email-dgilbert@redhat.com>

On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> A couple of typo fixes.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>   migration/rdma.c | 6 +++---
>   trace-events     | 4 ++--
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index bc73ff8..44ed996 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -1215,7 +1215,7 @@ const char *print_wrid(int wrid)
>
>   /*
>    * Perform a non-optimized memory unregistration after every transfer
> - * for demonsration purposes, only if pin-all is not requested.
> + * for demonstration purposes, only if pin-all is not requested.
>    *
>    * Potential optimizations:
>    * 1. Start a new thread to run this function continuously
> @@ -3279,7 +3279,7 @@ static void rdma_accept_incoming_migration(void *opaque)
>       QEMUFile *f;
>       Error *local_err = NULL, **errp = &local_err;
>
> -    trace_qemu_dma_accept_incoming_migration();
> +    trace_qemu_rdma_accept_incoming_migration();
>       ret = qemu_rdma_accept(rdma);
>
>       if (ret) {
> @@ -3287,7 +3287,7 @@ static void rdma_accept_incoming_migration(void *opaque)
>           return;
>       }
>
> -    trace_qemu_dma_accept_incoming_migration_accepted();
> +    trace_qemu_rdma_accept_incoming_migration_accepted();
>
>       f = qemu_fopen_rdma(rdma, "rb");
>       if (f == NULL) {
> diff --git a/trace-events b/trace-events
> index 2662ffa..8b468fe 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1398,8 +1398,8 @@ migrate_pending(uint64_t size, uint64_t max) "pending size %" PRIu64 " max %" PR
>   migrate_transferred(uint64_t tranferred, uint64_t time_spent, double bandwidth, uint64_t size) "transferred %" PRIu64 " time_spent %" PRIu64 " bandwidth %g max_size %" PRId64
>
>   # migration/rdma.c
> -qemu_dma_accept_incoming_migration(void) ""
> -qemu_dma_accept_incoming_migration_accepted(void) ""
> +qemu_rdma_accept_incoming_migration(void) ""
> +qemu_rdma_accept_incoming_migration_accepted(void) ""

What happened to the actual message inside the quotes? =)

  reply	other threads:[~2015-06-11 17:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 17:17 [Qemu-devel] [PATCH v2 00/12] Remove RDMA migration dependence on RAMBlock offset Dr. David Alan Gilbert (git)
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 01/12] Rename RDMA structures to make destination clear Dr. David Alan Gilbert (git)
2015-07-01  8:36   ` Juan Quintela
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 02/12] qemu_ram_foreach_block: pass up error value, and down the ramblock name Dr. David Alan Gilbert (git)
2015-07-01  8:36   ` Juan Quintela
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 03/12] Remove unneeded memset Dr. David Alan Gilbert (git)
2015-07-01  8:37   ` Juan Quintela
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 04/12] rdma typos Dr. David Alan Gilbert (git)
2015-06-11 17:56   ` Michael R. Hines [this message]
2015-06-11 18:37     ` Dr. David Alan Gilbert
2015-07-01  8:37   ` Juan Quintela
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 05/12] Store block name in local blocks structure Dr. David Alan Gilbert (git)
2015-07-01  8:38   ` Juan Quintela
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 06/12] Translate offsets to destination address space Dr. David Alan Gilbert (git)
2015-06-11 18:12   ` Michael R. Hines
2015-06-11 18:58     ` Dr. David Alan Gilbert
2015-06-11 19:08       ` Michael R. Hines
2015-06-12 18:50         ` Dr. David Alan Gilbert
2015-06-12 19:17           ` Michael R. Hines
2015-07-01  8:43   ` Juan Quintela
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load Dr. David Alan Gilbert (git)
2015-06-11 18:20   ` Michael R. Hines
2015-06-11 18:44     ` Dr. David Alan Gilbert
2015-07-01  8:47       ` Juan Quintela
2015-07-01  8:49   ` Juan Quintela
2015-07-01  8:51     ` Dr. David Alan Gilbert
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 08/12] Allow rdma_delete_block to work without the hash Dr. David Alan Gilbert (git)
2015-06-11 18:36   ` Michael R. Hines
2015-06-11 18:39     ` Dr. David Alan Gilbert
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 09/12] Rework ram block hash Dr. David Alan Gilbert (git)
2015-06-11 18:40   ` Michael R. Hines
2015-06-11 18:45     ` Dr. David Alan Gilbert
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 10/12] Sort destination RAMBlocks to be the same as the source Dr. David Alan Gilbert (git)
2015-06-11 18:55   ` Michael R. Hines
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 11/12] Sanity check RDMA remote data Dr. David Alan Gilbert (git)
2015-06-11 17:17 ` [Qemu-devel] [PATCH v2 12/12] Fail more cleanly in mismatched RAM cases Dr. David Alan Gilbert (git)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5579CBB6.8080604@linux.vnet.ibm.com \
    --to=mrhines@linux.vnet.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=dgilbert@redhat.com \
    --cc=mrhines@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.