From: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
To: Moritz Blume <moritz.blume@bmw-carit.de>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3 2/2] cmake: Upgrade 2.8.12.2 -> 3.2.2
Date: Thu, 11 Jun 2015 21:10:37 +0200 [thread overview]
Message-ID: <5579DD2D.10104@herbrechtsmeier.net> (raw)
In-Reply-To: <1433921778-1835-2-git-send-email-moritz.blume@bmw-carit.de>
Am 10.06.2015 um 09:36 schrieb Moritz Blume:
> Patches "qt4-fail-silent.patch" and "support-oe-qt4-tools-names.patch"
> were adapted in order to fit to CMake 3.2.2 (refer to the commit
> message in the respective patch for details).
> Patch "cmake-2.8.11.2-FindFreetype.patch" was dropped since it was
> rejected upstream and its functionality otherwise implemented in the
> meantime.
>
> Note that CMake 3 needs to have the full compiler path in the toolchain
> file (see cmake.bbclass).
Why is the full path needed?
Have you try to add STAGING_BINDIR_TOOLCHAIN to the CMAKE_FIND_ROOT_PATH?
<snip>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index 1ebb936..c97fd02 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -10,9 +10,11 @@ CCACHE = ""
> # We want the staging and installing functions from autotools
> inherit autotools
>
> -# C/C++ Compiler (without cpu arch/tune arguments)
> -OECMAKE_C_COMPILER ?= "`echo ${CC} | sed 's/^\([^ ]*\).*/\1/'`"
> -OECMAKE_CXX_COMPILER ?= "`echo ${CXX} | sed 's/^\([^ ]*\).*/\1/'`"
> +# Full path to C/C++ Compiler (without cpu arch/tune arguments)
> +C_COMPILER = "$(echo ${CC} | sed 's/^\([^ ]*\).*/\1/')"
> +CXX_COMPILER = "$(echo ${CXX} | sed 's/^\([^ ]*\).*/\1/')"
> +OECMAKE_C_COMPILER ?= "$(which ${C_COMPILER})"
> +OECMAKE_CXX_COMPILER ?= "$(which ${CXX_COMPILER})"
> OECMAKE_AR ?= "${AR}"
Why you don't use the full path for AR?
next prev parent reply other threads:[~2015-06-11 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 7:36 [PATCH v3 1/2] cmake: Whitespace fix Moritz Blume
2015-06-10 7:36 ` [PATCH v3 2/2] cmake: Upgrade 2.8.12.2 -> 3.2.2 Moritz Blume
2015-06-10 16:49 ` Burton, Ross
2015-06-10 19:41 ` Burton, Ross
2015-06-11 17:14 ` Stefan Herbrechtsmeier
2015-06-11 19:10 ` Stefan Herbrechtsmeier [this message]
2015-06-17 14:47 ` Moritz Blume
2015-06-18 12:30 ` Stefan Herbrechtsmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5579DD2D.10104@herbrechtsmeier.net \
--to=stefan@herbrechtsmeier.net \
--cc=moritz.blume@bmw-carit.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.