From: Daniel Borkmann <daniel@iogearbox.net>
To: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net-next] net: tcp: dctcp_update_alpha() fixes.
Date: Thu, 11 Jun 2015 23:07:32 +0200 [thread overview]
Message-ID: <5579F894.3030104@iogearbox.net> (raw)
In-Reply-To: <1433999477.27504.29.camel@edumazet-glaptop2.roam.corp.google.com>
On 06/11/2015 07:11 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> dctcp_alpha can be read by from dctcp_get_info() without
> synchro, so use WRITE_ONCE() to prevent compiler from using
> dctcp_alpha as a temporary variable.
>
> Also, playing with small dctcp_shift_g (like 1), can expose
> an overflow with 32bit values shifted 9 times before divide.
>
> Use an u64 field to avoid this problem, and perform the divide
> only if acked_bytes_ecn is not zero.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Change looks correct to me, thanks Eric!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
prev parent reply other threads:[~2015-06-11 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 5:11 [PATCH net-next] net: tcp: dctcp_update_alpha() fixes Eric Dumazet
2015-06-11 6:28 ` David Miller
2015-06-11 21:07 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5579F894.3030104@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.