From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers Date: Fri, 12 Jun 2015 05:48:54 +0200 Message-ID: <557A56A6.6010506@suse.com> References: <1434041849-27877-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434041849-27877-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xensource.com Cc: Wei Liu , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 06/11/2015 06:57 PM, Ian Jackson wrote: > Signed-off-by: Ian Jackson > CC: Ian Campbell > CC: Wei Liu > CC: Juergen Gross > --- > tools/libxl/libxl_internal.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h > index 465aaaa..bfc0729 100644 > --- a/tools/libxl/libxl_internal.h > +++ b/tools/libxl/libxl_internal.h > @@ -1911,8 +1911,9 @@ _hidden void libxl__egc_cleanup(libxl__egc *egc); > * All "slow" functions (see below for the exact definition) need to > * use the asynchronous operation ("ao") machinery. The function > * should take a parameter const libxl_asyncop_how *ao_how and must > - * start with a call to AO_INITIATOR_ENTRY. These functions MAY NOT > - * be called from inside libxl, because they can cause reentrancy > + * start with a call to AO_CREATE or equivalent. These functions MAY > + * NOT be called from inside libxl (regardless of what is passed for > + * ao_how), because they can cause reentrancy hazards due to > * callbacks. > * > * For the same reason functions taking an ao_how may make themselves > Now it's 100% clear what to avoid. Acked-by: Juergen Gross