From: Chanwoo Choi <cw00.choi@samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: balbi@ti.com, myungjoo.ham@samsung.com, k.kozlowski@samsung.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type
Date: Fri, 12 Jun 2015 13:43:29 +0900 [thread overview]
Message-ID: <557A6371.40300@samsung.com> (raw)
In-Reply-To: <20150612042741.GA10691@kroah.com>
Dear Greg,
On 06/12/2015 01:27 PM, Greg KH wrote:
> On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote:
>> This patch just redefine the unique id of supported external connectors without
>> 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to
>> indicate the specific external connectors like key number of input framework.
>> So, I have the plan to move this definitions to following header file which
>> includes the unique id of supported external connectors.
>> - include/dt-bindings/extcon/extcon.h
>>
>> Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> Dear Greg,
>>
>> I sent pull-request[1] of extcon for 4.2. This patch[2] in the pull-request[2]
>> includes the one issue about 'enum extcon'. The 'enum extcon' type is ambiguous
>> and not clear. So, if you possible, I hope you to pick this patch on char-misc
>> git repository.
>
> I don't understand, I took that pull request, right?
>
> What does that have to do with this patch?
This patch is based on patch[1] and then patch[1] was merged on char-misc-next branch (char-misc.git) through pull request.
[1] 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")
So, after reviewing this patch by you,
if this patch is ok, I hope that this patch will be applied to char-misc-next branch.
I'm sorry about un-clear explanation.
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2015-06-12 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 2:10 [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type Chanwoo Choi
2015-06-12 4:27 ` Greg KH
2015-06-12 4:43 ` Chanwoo Choi [this message]
2015-06-12 4:29 ` Greg KH
2015-06-12 5:04 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557A6371.40300@samsung.com \
--to=cw00.choi@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.