From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default
Date: Fri, 12 Jun 2015 09:35:37 +0200 [thread overview]
Message-ID: <557A8BC9.3020706@redhat.com> (raw)
In-Reply-To: <CANr=Z=ZCjKVUTAJWOmEf87i41KgcdAKF_JjJnHMXK=y1HxyWtg@mail.gmail.com>
Hi,
On 11-06-15 18:12, Joe Hershberger wrote:
> Hi Tom,
>
> On Thu, Jun 11, 2015 at 10:12 AM, Tom Rini <trini@konsulko.com> wrote:
>> On Thu, Jun 11, 2015 at 09:14:33AM -0500, Joe Hershberger wrote:
>>> Hi Tom,
>>>
>>> On Wed, Jun 3, 2015 at 5:12 PM, Tom Rini <trini@konsulko.com> wrote:
>>>> On Wed, Jun 03, 2015 at 08:12:16PM +0200, Hans de Goede wrote:
>>>>
>>>>> Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default rather then
>>>>> needing to have this in every sunxi defconfig file.
>>>>>
>>>>> This also fixes the Merrii_A80_Optimus defconfig no longer building.
>>>>>
>>>>> Cc: Maxin B. John <maxin.john@enea.com>
>>>>> Reported-by: Maxin B. John <maxin.john@enea.com>
>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>>
>>>> Joe? Masahiro? It feels like something has gone wrong with the
>>>> conversion here. Or do people need to get used to the defconfig files
>>>> being a non-trivial size? Or do we need some more default y if ...
>>>> lines around things? Or a few of the above? Thanks!
>>>
>>> I'm surprised you pulled this in for -rc2. I guess we can always revert it.
>>
>> OK, so where did we end up again exactly? Ah yes, (a) we can't
>> unexpectedly break peoples build. So I took this for now.
>
> This isn't fixing a breakage...
It does fix breakage as stated i the commit message the Merrii_A80_Optimus
target was broken by your patch, likely because your patch was generated
against a tree which did not have that one yet.
> it simply reduced the size of the sunxi boards' defconfig
That is because I choose a solution were I do not need to fix this over
and over again and one were something which comes pretty close to
pure noise was poluting all the sunxi defconfigs.
> and caused defconfig noise in every other
> board when running savedefconfig.
I did not realize that, sorry about that.
Regards,
Hans
next prev parent reply other threads:[~2015-06-12 7:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 18:12 [U-Boot] [PATCH] sunxi: Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default Hans de Goede
2015-06-03 19:09 ` Ian Campbell
2015-06-03 22:12 ` Tom Rini
2015-06-03 22:21 ` Joe Hershberger
2015-06-03 22:26 ` Tom Rini
2015-06-03 22:55 ` Joe Hershberger
2015-06-04 10:18 ` Hans de Goede
2015-06-04 17:29 ` Masahiro Yamada
2015-06-04 17:54 ` Joe Hershberger
2015-06-05 4:02 ` Masahiro Yamada
2015-06-05 16:25 ` Tom Rini
2015-06-10 14:09 ` Joe Hershberger
2015-06-10 14:05 ` Joe Hershberger
2015-06-11 14:14 ` Joe Hershberger
2015-06-11 15:12 ` Tom Rini
2015-06-11 16:12 ` Joe Hershberger
2015-06-12 7:35 ` Hans de Goede [this message]
2015-06-12 12:08 ` Tom Rini
2015-06-22 21:15 ` [U-Boot] [PATCH 0/7] Move include/config_cmd_default.h into Kconfig / remove arch defaults Joe Hershberger
2015-06-22 21:15 ` [U-Boot] [PATCH 1/7] mtd: spi: Add the SPI_FLASH config to Kconfig Joe Hershberger
2015-06-26 21:04 ` Tom Rini
2015-06-26 21:16 ` Jagan Teki
2015-06-22 21:15 ` [U-Boot] [PATCH 2/7] common: Fix comment for saveenv in Kconfig Joe Hershberger
2015-06-26 21:04 ` Tom Rini
2015-06-22 21:15 ` [U-Boot] [PATCH 3/7] common: Add the CMD_ENV_EXISTS config to Kconfig Joe Hershberger
2015-06-26 21:05 ` Tom Rini
2015-06-22 21:15 ` [U-Boot] [PATCH 4/7] arm: Make new baltos board not break on savedefconfig Joe Hershberger
2015-06-23 14:23 ` Tom Rini
2015-06-24 3:26 ` Joe Hershberger
2015-06-24 6:55 ` Yegor Yefremov
2015-06-24 7:33 ` Yegor Yefremov
2015-06-25 15:42 ` Joe Hershberger
2015-06-25 20:32 ` Yegor Yefremov
2015-06-25 15:48 ` Joe Hershberger
2015-06-25 16:17 ` Tom Rini
2015-06-26 21:05 ` Tom Rini
2015-06-22 21:15 ` [U-Boot] [PATCH 5/7] a3m071: Add needed dependency on LIB_RAND Joe Hershberger
2015-06-26 21:05 ` Tom Rini
2015-06-22 21:15 ` [U-Boot] [PATCH 6/7] Move default y configs out of arch/board Kconfig Joe Hershberger
2015-06-26 21:05 ` Tom Rini
2015-06-22 21:15 ` [U-Boot] [PATCH 7/7] Move defaults from config_cmd_default.h to Kconfig Joe Hershberger
2015-06-23 14:33 ` Tom Rini
2015-06-24 3:36 ` Joe Hershberger
2015-06-25 15:50 ` Joe Hershberger
2015-06-25 16:15 ` Tom Rini
2015-06-25 16:19 ` Joe Hershberger
2015-06-26 21:05 ` Tom Rini
2015-06-22 21:34 ` [U-Boot] [PATCH] sunxi: Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557A8BC9.3020706@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.