From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v3][PATCH 00/16] Fix RMRR Date: Fri, 12 Jun 2015 16:20:55 +0800 Message-ID: <557A9667.8020507@intel.com> References: <1433985325-16676-1-git-send-email-tiejun.chen@intel.com> <20150611125200.GC1818@deinos.phlegethon.org> <557A3F86.9090607@intel.com> <557AAE9E020000780008403C@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <557AAE9E020000780008403C@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Tim Deegan , kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org On 2015/6/12 16:04, Jan Beulich wrote: >>>> On 12.06.15 at 04:10, wrote: >> On 2015/6/11 20:52, Tim Deegan wrote: >>> which would be better handeld explicitly: >>> >>> if ( p2mt == p2m_invalid || p2mt == p2m_mmio_dm ) >>> ... >>> >> >> So if I'm correct, we should do this check explicitly, >> >> if ( p2mt == p2m_invalid || >> (p2mt == p2m_mmio_dm && !mfn_valid(mfn) ) >> >> Note this is equivalent to Jan's comment. > > I think the !mfn_valid() part is really redundant - p2m_mmio_dm > should never be put on a page translating to a valid MFN. > I'm not sure immediately but I believe you're definitely right at this point, so lets goes there :) Thanks Tiejun