From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v3][PATCH 04/16] xen/passthrough: extend hypercall to support rdm reservation policy Date: Fri, 12 Jun 2015 17:20:56 +0800 Message-ID: <557AA478.6070203@intel.com> References: <1433985325-16676-1-git-send-email-tiejun.chen@intel.com> <1433985325-16676-5-git-send-email-tiejun.chen@intel.com> <557A7CA7.9000305@intel.com> <557AB84A02000078000840CD@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <557AB84A02000078000840CD@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "tim@xen.org" , Kevin Tian , "wei.liu2@citrix.com" , "ian.campbell@citrix.com" , "andrew.cooper3@citrix.com" , "Ian.Jackson@eu.citrix.com" , "xen-devel@lists.xen.org" , "stefano.stabellini@citrix.com" , Yang Z Zhang List-Id: xen-devel@lists.xenproject.org On 2015/6/12 16:45, Jan Beulich wrote: >>>> On 12.06.15 at 08:31, wrote: >> On 2015/6/11 17:28, Tian, Kevin wrote: >>>> From: Chen, Tiejun >>>> Sent: Thursday, June 11, 2015 9:15 AM >>>> @@ -1940,7 +1942,8 @@ static int intel_iommu_remove_device(u8 devfn, struct pci_dev >>>> *pdev) >>>> PCI_DEVFN2(bdf) != devfn ) >>>> continue; >>>> >>>> - rmrr_identity_mapping(pdev->domain, 0, rmrr); >>>> + rmrr_identity_mapping(pdev->domain, 0, rmrr, >>>> + XEN_DOMCTL_DEV_RDM_RELAXED); >>> >>> ditto >> >> It doesn't matter when we're trying to remove a device since we don't >> care this flag. > > In such a case it helps to add a brief comment saying that the precise > value passed is irrelevant. Or maybe this could be expressed by Okay. > folding this and the "map" parameters of the function (in which case it > might become self-documenting)? > Sorry, I don't know exactly how to implement this idea. Have we any similar example on Xen side? Thanks Tiejun