Re: [PATCH] Only invoke RPM on RPM-enabled Linux distributions

[Petr Lautrbach <plautrba@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

Dne 11.6.2015 v 17:22 Sven Vermeulen napsal(a):
> On Tue, Jun 09, 2015 at 08:19:24AM -0400, Stephen Smalley wrote:
>> On 06/09/2015 07:26 AM, Sven Vermeulen wrote:
>>> In this patch, we use the Python platform module to get the Linux
>>> distribution, and only start the RPM-related activities on Linux
>>> distributions that use RPM as their native package manager.
>>>
>>> Signed-off-by: Sven Vermeulen <sven.vermeulen@siphos.be>
>>
>> Is there a more general way that we could do this without hardcoding
>> checks of distribution names?  Maybe we could just test for the
>> existence of rpm?
> 
> That wouldn't be sufficient.
> 
> The rpm binary might be installed for other reasons. The code in sepolicy is
> used to query the rpm database and search for specific package names. This
> is distribution-specific behavior.
> 
> If you rather check on the rpm binary, then additional checks will need to
> be added to make sure that the assumptions that the code takes (such as
> "selinux-policy" package being available) are valid as well.


It might be useful to amend the code to check a return value of
get_rpm_nvr_list(). If it's None, you can assume that rpm is not
installed since rpmlib is probably unusable or there's no valid rpm
database entries.

Petr
-- 
Petr Lautrbach



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]