From: Chris Mason <clm@fb.com>
To: Mark Fasheh <mfasheh@suse.de>, <linux-btrfs@vger.kernel.org>
Cc: Josef Bacik <jbacik@fb.com>, Matt Robinson <git@nerdoftheherd.com>
Subject: Re: [RESEND][PATCH] btrfs: Align EOF length to block in extent_same
Date: Fri, 12 Jun 2015 16:18:25 -0400 [thread overview]
Message-ID: <557B3E91.3060206@fb.com> (raw)
In-Reply-To: <20150610221355.GN18148@wotan.suse.de>
On 06/10/2015 06:13 PM, Mark Fasheh wrote:
> Hi,
>
> Can this patch please be considered for upstream inclusion? I reviewed
> it myself and have tested it on a few files with an updated duperemove
> branch:
>
> https://github.com/markfasheh/duperemove/tree/alignment_fix
>
> as described below, this allows us to dedupe the tail extents of files
> whose size is not block aligned. I have reports from users who hit
> this bug and as a result don't get any space savings and I believe this
> should help them out quite a bit.
Hi Mark,
This one conflicts with your btrfs: Handle unaligned length in
extent_same, which is in integration now. If we need both, can you
please rework it?
-chris
next prev parent reply other threads:[~2015-06-12 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 22:13 [RESEND][PATCH] btrfs: Align EOF length to block in extent_same Mark Fasheh
2015-06-11 8:56 ` Liu Bo
2015-06-12 20:18 ` Chris Mason [this message]
2015-06-12 22:56 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557B3E91.3060206@fb.com \
--to=clm@fb.com \
--cc=git@nerdoftheherd.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.