From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48605)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dirty.ice.hu@gmail.com>) id 1Z3XvG-0007TB-BK
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:59:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dirty.ice.hu@gmail.com>) id 1Z3XvC-0001Xs-BN
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:59:38 -0400
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:37206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dirty.ice.hu@gmail.com>) id 1Z3XvC-0001Wu-3O
	for qemu-devel@nongnu.org; Fri, 12 Jun 2015 18:59:34 -0400
Received: by wifx6 with SMTP id x6so28241589wif.0
	for <qemu-devel@nongnu.org>; Fri, 12 Jun 2015 15:59:33 -0700 (PDT)
From: "=?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?=" <dirty.ice.hu@gmail.com>
Message-ID: <557B6457.4020304@gmail.com>
Date: Sat, 13 Jun 2015 00:59:35 +0200
MIME-Version: 1.0
References: <cover.1434111578.git.DirtY.iCE.hu@gmail.com>
	<5dee9d7d95eb2260edcc0de0d1090366f159b03f.1434111578.git.DirtY.iCE.hu@gmail.com>
	<557B592E.20103@redhat.com>
In-Reply-To: <557B592E.20103@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 07/12] qapi: qapi for audio backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

2015-06-13 00:11 keltezéssel, Eric Blake írta:
>> +##
>> +# @AudiodevAlsaOptions
>> +#
>> +# Options of the alsa audio backend.
>> +#
>> +# @in: #optional options of the capture stream
>> +#
>> +# @out: #optional options of the playback stream
>
> Marked optional here...
>
>> +#
>> +# @threshold: #optional set the threshold (in frames) when playback starts
>> +#
>> +# Since: 2.4
>> +##
>> +{ 'struct': 'AudiodevAlsaOptions',
>> +  'data': {
>> +    'in':         'AudiodevAlsaPerDirectionOptions',
>> +    'out':        'AudiodevAlsaPerDirectionOptions',
>
> ...but not here.

Oups. The code is the correct (they are not optional), I forgot updating 
the documentation. (Same goes for the other mismatches).

>
>> +    '*threshold': 'int' } }
>> +
>> +##
>> +# @AudiodevDsoundOptions
>> +#
>> +# Options of the dsound audio backend.
>> +#
>> +# @latency-millis: #optional add extra latency to playback
>> +#
>> +# Since: 2.4
>> +##
>> +{ 'struct': 'AudiodevDsoundOptions',
>> +  'data': {
>> +    '*latency-millis': 'int' } }
>
> Style question - should we just call this 'latency', and document the
> milliseconds unit in the description? But having the name latency_millis
> in C code might not be all that bad, so you may not want to change this one.

There is also a buffer-usecs, so I vote for keeping latency-millis. Also 
there is timer-period in Audiodev. Maybe it should be renamed to 
timer-period-hz, to keep consistency. Or maybe change all of them to usecs.


Other issues acked.

Thanks,
Zoltan