All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergej Sawazki <ce3a@gmx.de>
To: broonie@kernel.org, gregkh@linuxfoundation.org,
	w.sang@pengutronix.de, wsa@the-dreams.de
Cc: linux-kernel@vger.kernel.org
Subject: [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151
Date: Sat, 13 Jun 2015 15:21:02 +0200	[thread overview]
Message-ID: <557C2E3E.80000@gmx.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

Hello all,

when I try to read the register values of a i2c ASoC codec through
debugfs, (eg: cat /sys/kernel/debug/regmap/1-001a/registers)
I am getting an WARN_ON at drivers/base/regmap/regmap-debugfs.c:151.
Please see attached dmesg.txt for details.

I did some debugging and found that regmap_readable(), at regmap-
debugfs.c:109, returns "false" for all registers, hence the 
debugfs_off_cache list remains empty and we get an warning in line 151.

Reverting commit 4191f1979 "regmap: if format_write is used, declare
all registers as "unreadable"" fixed the issue.

Regards,
Sergej

[-- Attachment #2: dmesg.txt --]
[-- Type: text/plain, Size: 1572 bytes --]

[  507.037105] ------------[ cut here ]------------
[  507.037173] WARNING: CPU: 0 PID: 2609 at drivers/base/regmap/regmap-debugfs.c:151 regmap_debugfs_get_dump_start.part.0+0x210/0x26c()
[  507.037188] Modules linked in: 8192cu snd_soc_wm8741 regmap_spi snd_soc_bcm2708_i2s regmap_mmio snd_soc_tau_dac
snd_soc_core snd_compress snd_pcm_dmaengine snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_midi snd_rawmidi snd_seq_oss snd_seq_midi_ev
ent snd_seq snd_seq_device snd_timer clk_si5351 regmap_i2c snd i2c_bcm2708 sg uio_pdrv_genirq uio
[  507.037320] CPU: 0 PID: 2609 Comm: cat Tainted: G        W      3.18.7-tau-dac-00032-g604bbbc-dirty #54
[  507.037388] [<c00158e4>] (unwind_backtrace) from [<c0012c40>] (show_stack+0x20/0x24)
[  507.037438] [<c0012c40>] (show_stack) from [<c0554008>] (dump_stack+0x20/0x28)
[  507.037480] [<c0554008>] (dump_stack) from [<c0023608>] (warn_slowpath_common+0x7c/0x9c)
[  507.037511] [<c0023608>] (warn_slowpath_common) from [<c0023654>] (warn_slowpath_null+0x2c/0x34)
[  507.037539] [<c0023654>] (warn_slowpath_null) from [<c0375a30>] (regmap_debugfs_get_dump_start.part.0+0x210/0x26c)
[  507.037569] [<c0375a30>] (regmap_debugfs_get_dump_start.part.0) from [<c0375b30>] (regmap_reg_ranges_read_file+0xa4/0x280)
[  507.037609] [<c0375b30>] (regmap_reg_ranges_read_file) from [<c0136a0c>] (vfs_read+0x98/0x184)
[  507.037639] [<c0136a0c>] (vfs_read) from [<c0136b44>] (SyS_read+0x4c/0x98)
[  507.037668] [<c0136b44>] (SyS_read) from [<c000f580>] (ret_fast_syscall+0x0/0x48)
[  507.037684] ---[ end trace b52574e72eb4e3d1 ]---

             reply	other threads:[~2015-06-13 13:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13 13:21 Sergej Sawazki [this message]
2015-06-15  9:49 ` [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151 Mark Brown
2015-06-15 12:42   ` Sergej Sawazki
2015-06-15 14:49     ` Mark Brown
2015-06-24 20:49       ` Sergej Sawazki
2015-07-07 22:42         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557C2E3E.80000@gmx.de \
    --to=ce3a@gmx.de \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.