From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v2 COLOPre 13/13] tools/libxl: don't touch remus in checkpoint_device Date: Mon, 15 Jun 2015 09:46:49 +0800 Message-ID: <557E2E89.50201@cn.fujitsu.com> References: <1433734997-26570-1-git-send-email-yanghy@cn.fujitsu.com> <1433734997-26570-14-git-send-email-yanghy@cn.fujitsu.com> <20150612132857.GP14606@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150612132857.GP14606@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.campbell@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 06/12/2015 09:28 PM, Wei Liu wrote: > On Mon, Jun 08, 2015 at 11:43:17AM +0800, Yang Hongyang wrote: >> Checkpoint device is an abstract layer to do checkpoint. >> COLO can also use it to do checkpoint. But there are >> still some codes in checkpoint device which touch remus: >> 1. remus_ops: we use remus ops directly in checkpoint >> device. Store it in checkpoint device state. >> 2. concrete layer's private member: add a new structure >> remus state, and move them to remus state. >> 3. init/cleanup device subkind: we call (init|cleanup)_subkind_nic >> and (init|cleanup)_subkind_drbd_disk directly in checkpoint >> device. Call them before calling libxl__checkpoint_devices_setup() >> or after calling libxl__checkpoint_devices_teardown(). >> > >>>From the look of it this patch is mostly refactoring and doesn't involve > functional changes, right? If so please state that in commit message. Yes, it is refactoring and no functional changes, will mention it in next version. > > I suppose this needs review from remus maintainer. > > Wei. > . > -- Thanks, Yang.