All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] insane.bbclass: check invalid ac_cv value
Date: Mon, 15 Jun 2015 13:21:04 +0800	[thread overview]
Message-ID: <557E60C0.90708@windriver.com> (raw)
In-Reply-To: <CAJTo0LaAv9NoBrGgW=52aTg0dRUTAvAP4SNw+3B4jVu5a3GM6w@mail.gmail.com>



On 06/12/2015 07:06 PM, Burton, Ross wrote:
>
> On 12 June 2015 at 04:23, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
>     +        for var in tocheck.split():
>     +            if var.startswith('ac_cv_'):
>     +                varname = var.split('=')[0]
>     +                cfgscript=d.expand("${S}/configure")
>     +                if os.path.exists(cfgscript):
>     +                    statement = "grep -q -F %s  %s > /dev/null" % (varname,
>     cfgscript)
>
>
> So your assumption that ac_cv_* variables are referenced in full in configure is
> bad.  This is what strace has for the giant AC_CHECK_HEADERS block:

Yes, it doesn't work well, I will try to figure out other ways.

// Robert

>
> for ac_header in asm/cachectl.h asm/sysmips.h bluetooth/bluetooth.h elf.h
> inttypes.h ioctls.h linux/bsg.h linux/falloc.h linux/filter.h linux/hiddev.h
> linux/mmtimer.h linux/perf_event.h linux/seccomp.h linux/securebits.h
> linux/utsname.h mqueue.h netinet/sctp.h poll.h scsi/sg.h stropts.h sys/conf.h
> sys/epoll.h sys/fanotify.h sys/filio.h sys/ioctl.h sys/poll.h sys/reg.h
> sys/vfs.h sys/xattr.h
> do :
>    as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
> ac_fn_c_check_header_mongrel "$LINENO" "$ac_header" "$as_ac_Header"
> "$ac_includes_default"
>
> The variable name is constructed, so this test can't work.
>
> Ross


  reply	other threads:[~2015-06-15  5:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  3:23 [PATCH 0/2] Add invalid-ac-cv QA and and remove invalid ac_cv Robert Yang
2015-06-12  3:23 ` [PATCH 1/2] insane.bbclass: check invalid ac_cv value Robert Yang
2015-06-12 11:06   ` Burton, Ross
2015-06-15  5:21     ` Robert Yang [this message]
2015-06-12  3:23 ` [PATCH 2/2] Remove invalid ac_cv Robert Yang
2015-06-12 11:02   ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557E60C0.90708@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.