From: Mason <slash.tmp@free.fr>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [Semaphore API] down_interruptible_timeout
Date: Mon, 15 Jun 2015 10:43:28 +0200 [thread overview]
Message-ID: <557E9030.6080901@free.fr> (raw)
Hello,
The semaphore API provides several flavors of the down primitive:
down, down_interruptible, down_killable, down_trylock, down_timeout
As far as I can tell, they all call __down_common (except down_trylock,
which returns 1 where the others would sleep).
I was looking for a version
1) with a timeout
2) that could be interrupted
e.g. down_interruptible_timeout, but it doesn't exist.
It seems
__down_common(sem, TASK_INTERRUPTIBLE, timeout);
would work as expected, no?
Do you know why it is not offered?
(Maybe there is a better way to achieve the same thing?)
[POST SCRIPTUM EDIT]
I found this 2007 discussion:
http://thread.gmane.org/gmane.linux.kernel/498034
At the time, Andrew said
"Nobody else has needed to invent new locking infrastructure
to do such things and I'd prefer not to do so now."
I suppose this is still true :-)
[/EDIT]
My use-case is pretty simple:
A) process-context kernel thread fills a FIFO and calls down(&fifo_empty);
B) ISR handles the FIFO-empty interrupt with up(&fifo_empty);
However, in case something goes wrong and the interrupt never fires,
I don't want the process to be stuck in an uninterruptible sleep.
Perhaps I can set a tiny timeout (e.g. 10 µs) and not worry about
the interruptible part for such a small duration? (Hmm, __down_common
calls schedule_timeout, which is jiffies-based. I don't think there
is a hrtimers flavor. So µs timeouts would be off the table?)
Or I could use the interruptible version, and let the user kill the
operation if necessary.
I'd like to hear your comments and suggestions.
Regards.
next reply other threads:[~2015-06-15 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 8:43 Mason [this message]
2015-06-15 16:56 ` [Semaphore API] down_interruptible_timeout Thomas Gleixner
2015-06-16 15:43 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557E9030.6080901@free.fr \
--to=slash.tmp@free.fr \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.