All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: Daiane Angolini <daiane.list@gmail.com>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [PATCH] image_types_fsl: Fix sdcard build error
Date: Mon, 15 Jun 2015 06:11:50 -0600	[thread overview]
Message-ID: <557EC106.1070502@mlbassoc.com> (raw)
In-Reply-To: <CA+jg_OX=2ky_2d9VROV9APaN0f+HK59s=7uj2Z8OoCYfcE9giw@mail.gmail.com>

On 2015-06-15 04:59, Daiane Angolini wrote:
> On Sun, Jun 14, 2015 at 3:08 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> Recent updates to the MSDOS tools (OE-core is now at 3.0.28) have made
>> it an error to overwrite an image using mkfs.vfat.  This patch fixes
>> that problem by removing any old/stale images, thus starting from scratch.
>
> Hi Gary,
>
> Would you mind to share the symptom which made you think about this patch?
>
> I faced some crazy errors last week I though was caused by my sdcard
> adaptor (which is not exactly reliable) and I want to double check.
>
> No problem with your patch... only asking

Without the patch, generating the .sdcard image failed (i.e. big red error!)
in the do_rootfs step.

>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>>   classes/image_types_fsl.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
>> index 1ebcb06..b542549 100644
>> --- a/classes/image_types_fsl.bbclass
>> +++ b/classes/image_types_fsl.bbclass
>> @@ -152,6 +152,7 @@ generate_imx_sdcard () {
>>          # Create boot partition image
>>          BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDCARD} unit b print \
>>                            | awk '/ 1 / { print substr($4, 1, length($4 -1)) / 1024 }')
>> +        rm -f ${WORKDIR}/boot.img
>>          mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
>>          mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
>>
>> @@ -255,6 +256,7 @@ generate_mxs_sdcard () {
>>                  BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDCARD} unit b print \
>>                  | awk '/ 2 / { print substr($4, 1, length($4 -1)) / 1024 }')
>>
>> +               rm -f ${WORKDIR}/boot.img
>>                  mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
>>                  mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
>>                  if test -n "${KERNEL_DEVICETREE}"; then
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-06-15 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14 18:08 [PATCH] image_types_fsl: Fix sdcard build error Gary Thomas
2015-06-15 10:59 ` Daiane Angolini
2015-06-15 12:11   ` Gary Thomas [this message]
2015-06-15 13:06     ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557EC106.1070502@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=daiane.list@gmail.com \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.