From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Alberto Garcia <berto@igalia.com>
Subject: Re: [Qemu-devel] [PULL 06/10] throttle: Add throttle group support
Date: Mon, 15 Jun 2015 06:33:07 -0600 [thread overview]
Message-ID: <557EC603.5060805@redhat.com> (raw)
In-Reply-To: <1434121078-15776-7-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On 06/12/2015 08:57 AM, Stefan Hajnoczi wrote:
> From: Alberto Garcia <berto@igalia.com>
>
> The throttle group support use a cooperative round robin scheduling
> algorithm.
>
> The principles of the algorithm are simple:
> - Each BDS of the group is used as a token in a circular way.
> - The active BDS computes if a wait must be done and arms the right
> timer.
> - If a wait must be done the token timer will be armed so the token
> will become the next active BDS.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Message-id: f0082a86f3ac01c46170f7eafe2101a92e8fde39.1433779731.git.berto@igalia.com
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> +++ b/qapi/block-core.json
> @@ -1062,6 +1062,27 @@
> #
> # Change I/O throttle limits for a block drive.
> #
> +#
> +# I/O limits can be disabled by setting all of them to 0. In this case
> +# the device will be removed from its group and the rest of its
> +# members will no be affected. The 'group' parameter is ignored.
s/no/not/
(can be done in a followup patch, since this is already a pull request)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-06-15 12:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 14:57 [Qemu-devel] [PULL 00/10] Block patches Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 01/10] Revert "iothread: release iothread around aio_poll" Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 02/10] raw-posix: Fix .bdrv_co_get_block_status() for unaligned image size Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 03/10] throttle: Extract timers from ThrottleState into a separate structure Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 04/10] throttle: Add throttle group infrastructure Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 05/10] throttle: Add throttle group infrastructure tests Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 06/10] throttle: Add throttle group support Stefan Hajnoczi
2015-06-15 12:33 ` Eric Blake [this message]
2015-06-12 14:57 ` [Qemu-devel] [PULL 07/10] throttle: acquire the ThrottleGroup lock in bdrv_swap() Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 08/10] throttle: add the name of the ThrottleGroup to BlockDeviceInfo Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 09/10] throttle: Update throttle infrastructure copyright Stefan Hajnoczi
2015-06-12 14:57 ` [Qemu-devel] [PULL 10/10] qemu-iotests: expand test 093 to support group throttling Stefan Hajnoczi
2015-06-15 9:42 ` [Qemu-devel] [PULL 00/10] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557EC603.5060805@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.