All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ruprecht <andreas.ruprecht@fau.de>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Peter Hurley <peter@hurleysoftware.com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Stefan Hengelein <stefan.hengelein@fau.de>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	Paul Bolle <pebolle@tiscali.nl>
Subject: serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE
Date: Mon, 15 Jun 2015 14:45:37 +0200	[thread overview]
Message-ID: <557EC8F1.9010305@fau.de> (raw)

Hi Maxime,

your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
was merged into linux-next today (i.e., next-20150615), and contains the
following piece of code:

[...]
#if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&
defined(CONFIG_MAGIC_SYSRQ)
#define SUPPORT_SYSRQ
#endif
[...]

The #if block can never be enabled as no symbol named
SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean
SERIAL_STM32_CONSOLE which you introduce in the same commit?

I detected the issue by running undertaker-checkpatch from the
Undertaker tool suite (https://undertaker.cs.fau.de). There is also a
tool in the Linux tree itself that can detect such issues
(scripts/checkkconfigsymbols.py).

Regards,

Andreas

             reply	other threads:[~2015-06-15 12:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 12:45 Andreas Ruprecht [this message]
2015-06-16  8:47 ` serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557EC8F1.9010305@fau.de \
    --to=andreas.ruprecht@fau.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=pebolle@tiscali.nl \
    --cc=peter@hurleysoftware.com \
    --cc=stefan.hengelein@fau.de \
    --cc=valentinrothberg@gmail.com \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.