From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 3/6] gnttab: simplify shared entry v1 vs v2 handling Date: Mon, 15 Jun 2015 14:30:56 +0100 Message-ID: <557ED390.1090700@citrix.com> References: <557EDDDD0200007800084C94@mail.emea.novell.com> <557EE0A80200007800084CD9@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z4UTe-0008SW-NV for xen-devel@lists.xenproject.org; Mon, 15 Jun 2015 13:31:02 +0000 In-Reply-To: <557EE0A80200007800084CD9@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Ian Campbell , Ian Jackson , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 15/06/15 13:26, Jan Beulich wrote: > In a number of places both v1 and v2 pointers are being obtained when > none or just one suffices. Additionally in __acquire_grant_for_copy() > the flow of if/else-if can be slightly improved by re-ordering. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper