From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256
Date: Mon, 15 Jun 2015 18:19:21 +0100
Message-ID: <557F0919.6020909@citrix.com>
References: <1433849019-27452-1-git-send-email-olaf@aepfle.de>
	<1433849019-27452-3-git-send-email-olaf@aepfle.de>
	<55789E1C.9030504@citrix.com> <20150611061226.GA22268@aepfle.de>
	<55796B1C.9020309@citrix.com> <55799CBA.3020005@eu.citrix.com>
	<20150615161451.GA29475@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150615161451.GA29475@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>, George Dunlap <george.dunlap@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Julien Grall <julien.grall@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 15/06/15 17:14, Olaf Hering wrote:
> On Thu, Jun 11, George Dunlap wrote:
>
>> On 06/11/2015 12:03 PM, Julien Grall wrote:
>>> I would suggest some refactoring to remove NR_CPUS and associated code
>>> in order to avoid mis-usage later.
>>>
>>> Also, cpu_mask_t is a uint32_t, is it intentional?
>> When xenalyze was originally written back in 2006, I think that's
>> probably how it was defined in Xen.  I just haven't used it on a system
>> with more than 32 cpus. :-)
>>
>> That certainly should be addressed at some point.  I'd be in favor of
>> checking this in and fixing it up later; or, for the time being, just
>> disabling the skew detection functionality (which is the only place that
>> uses it, AFAICT).
> Today I looked at this part:
>
> In v6 I have added a patch to remove cpumask_t. Now I see xenalyze.c has
> a cpu_mask_t with just 32 bits. Easy change would be to change that to
> uin64_t.
>
> To really support MAX_CPUS the code can either include
> xen/include/xen/cpumask.h, or just the few required functions can be
> pasted into xenalyze.c.
>
> What do you prefer?

In an ideal world, userspace tools like this should not really be tied
to NR_CPUS or MAX_CPUS.  They should get max_cpu_id from Xen and
dynamically allocate a bitmap of sufficient size.

Whether this is a yak worth shaving now is a different matter.

~Andrew