From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: Reinstate order of operations in {intel, logical}_ring_begin() Date: Mon, 15 Jun 2015 19:11:37 +0100 Message-ID: <557F1559.9040202@intel.com> References: <1433789496-8365-1-git-send-email-david.s.gordon@intel.com> <20150615091520.GU28462@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D2356E50E for ; Mon, 15 Jun 2015 11:11:39 -0700 (PDT) In-Reply-To: <20150615091520.GU28462@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Alex Dai List-Id: intel-gfx@lists.freedesktop.org T24gMTUvMDYvMTUgMTA6MTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIEp1biAwOCwg MjAxNSBhdCAwNzo1MTozNlBNICswMTAwLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4gVGhlIG9yaWdp bmFsIGlkZWEgb2YgcHJlYWxsb2NhdGluZyB0aGUgT0xSIHdhcyBpbXBsZW1lbnRlZCBpbgo+Pgo+ Pj4gOWQ3NzMwOTEgZHJtL2k5MTU6IFByZWFsbG9jYXRlIG5leHQgc2Vxbm8gYmVmb3JlIHRvdWNo aW5nIHRoZSByaW5nCj4+Cj4+IGFuZCB0aGUgc2VxdWVuY2Ugb2Ygb3BlcmF0aW9ucyB3YXMgdG8g YWxsb2NhdGUgdGhlIE9MUiwgdGhlbiB3cmFwIHBhc3QKPj4gdGhlIGVuZCBvZiB0aGUgcmluZyBp ZiBuZWNlc3NhcnksIHRoZW4gd2FpdCBmb3Igc3BhY2UgaWYgbmVjZXNzYXJ5Lgo+PiBCdXQgc3Vi c2VxdWVudGx5IGludGVsX3JpbmdfYmVnaW4oKSB3YXMgcmVmYWN0b3JlZCwgaW4KPj4KPj4+IDMw NGQ2OTUgZHJtL2k5MTU6IEZsdXNoIG91dHN0YW5kaW5nIHJlcXVlc3RzIGJlZm9yZSBhbGxvY2F0 aW5nIG5ldyBzZXFubwo+Pgo+PiB0byBlbnN1cmUgdGhhdCBwZW5kaW5nIHdvcmsgdGhhdCBtaWdo dCBuZWVkIHRvIGJlIGZsdXNoZWQgdXNlZCB0aGUgb2xkCj4+IGFuZCBub3QgdGhlIG5ld2x5LWFs bG9jYXRlZCByZXF1ZXN0LiBUaGlzIGNoYW5nZWQgdGhlIHNlcXVlbmNlIHRvIHdyYXAKPj4gYW5k L29yIHdhaXQsIHRoZW4gYWxsb2NhdGUsIGFsdGhvdWdoIHRoZSBjb21tZW50IHN0aWxsIHNhaWQK Pj4gCS8qIFByZWFsbG9jYXRlIHRoZSBvbHIgYmVmb3JlIHRvdWNoaW5nIHRoZSByaW5nICovCj4+ IHdoaWNoIHdhcyBubyBsb25nZXIgdHJ1ZSBhcyBpbnRlbF93cmFwX3JpbmdfYnVmZmVyKCkgdG91 Y2hlcyB0aGUgcmluZy4KPj4KPj4gVGhlIHJldmVyc2FsIGRpZG4ndCBpbnRyb2R1Y2UgYW55IHBy b2JsZW1zIHVudGlsIHRoZSBpbnRyb2R1Y3Rpb24gb2YKPj4gZHluYW1pYyBwaW5uaW5nLCBpbgo+ Pgo+Pj4gN2JhNzE3YyBkcm0vaTkxNS9iZHc6IFBpbiB0aGUgcmluZ2J1ZmZlciBiYWNraW5nIG9i amVjdCB0byBHR1RUIG9uLWRlbWFuZAo+Pgo+PiBXaXRoIHRoYXQgY2FtZSB0aGUgcG9zc2liaWxp dHkgdGhhdCB0aGUgcmluZ2J1ZmZlciBtaWdodCBub3QgYmUgcGlubmVkCj4+IHRvIHRoZSBHVFQg b3IgbWFwcGVkIGludG8gQ1BVIGFkZHJlc3Mgc3BhY2Ugd2hlbiBpbnRlbF9yaW5nX2JlZ2luKCkK Pj4gaXMgY2FsbGVkLiBJdCBnZXRzIHBpbm5lZCB3aGVuIHRoZSByZXF1ZXN0IGlzIGFsbG9jYXRl ZCwgc28gaXQncyBub3cKPj4gaW1wb3J0YW50IHRoYXQgdGhpcyBjb21lcyBiZWZvcmUgKmFueXRo aW5nKiB0aGF0IGNhbiB3cml0ZSBpbnRvIHRoZQo+PiByaW5nYnVmZmVyLCBzcGVjaWZpY2FsbHkg aW50ZWxfd3JhcF9yaW5nX2J1ZmZlcigpLCBhcyB0aGlzIHdpbGwgZmF1bHQgaWYKPj4gKGEpIHRo ZSByaW5nYnVmZmVyIGhhcHBlbnMgbm90IHRvIGJlIG1hcHBlZCwgYW5kIChiKSB0YWlsIGhhcHBl bnMgdG8gYmUKPj4gc3VmZmljaWVudGx5IGNsb3NlIHRvIHRoZSBlbmQgb2YgdGhlIHJpbmcgdG8g dHJpZ2dlciB3cmFwcGluZy4KPj4KPj4gVGhlIG9yaWdpbmFsIHJhdGlvbmFsZSBmb3IgdGhpcyBy ZXZlcnNhbCBzZWVtcyB0byBubyBsb25nZXIgYXBwbHksCj4+IGFzIHdlIHNob3VsZG4ndCBldmVy IGhhdmUgYW55dGhpbmcgaW4gdGhlIHJpbmdidWZmZXIgd2hpY2ggaXMgbm90Cj4+IGFzc29jaWF0 ZWQgd2l0aCBhIHNwZWNpZmljIHJlcXVlc3QsIGFuZCB0aGVyZWZvcmUgc2hvdWxkbid0IGhhdmUg YW55dGhpbmcKPj4gdG8gZmx1c2guICBTbyBpdCBzaG91bGQgbm93IGJlIHNhZmUgdG8gcmVpbnN0 YXRlIHRoZSBvcmlnaW5hbCBzZXF1ZW5jZQo+PiBvZiBhbGxvY2F0ZS13cmFwLXdhaXQgOikKPiAK PiBJdCBzdGlsbCBhcHBsaWVzLiBJZiB5b3Ugc3VibWl0IHNheSAxMDI0IGludGVycnVwdGVkIGV4 ZWNidWZmZXJzIHRoZXkKCldoYXQgaXMgYW4gaW50ZXJydXB0ZWQgZXhlY2J1ZmZlcj8gQUZBSUNU IHdlIGhvbGQgdGhlIHN0cnVjdF9tdXRleCB3aGlsZQpzdHVmZmluZyB0aGUgcmluZ2J1ZmZlciBz byB3ZSBjYW4gb25seSBldmVyIGJlIGluIHRoZSBwcm9jZXNzIG9mIGFkZGluZwppbnN0cnVjdGlv bnMgdG8gb25lIHJpbmdidWZmZXIgYXQgYSB0aW1lLCBhbmQgd2UgZG9uJ3QgKG5vdykgaW50ZXJs ZWF2ZQphbnkgZmxpcCBjb21tYW5kcyAoZXhlY2xpc3RzIG1vZGUgcmVxdWlyZXMgbW1pbyBmbGlw KS4gSXMgdGhlcmUgc3RpbGwKc29tZXRoaW5nIHRoYXQganVzdCBhZGRzIHJhbmRvbSBzdHVmZiB0 byBzb21lb25lIGVsc2UncyBPTFI/Cgo+IGFsbCBzaGFyZSB0aGUgc2FtZSByZXF1ZXN0LiBUaGVu IHNvIGRvZXMgdGhlIDEwMjUuIEV4Y2VwdCB0aGUgMTAyNXRoCj4gKGZvciB0aGUgc2FrZSBvZiBh cmd1bWVudCkgcmVxdWlyZXMgZXh0cmEgc3BhY2Ugb24gdGhlIHJpbmcuIFRvIG1ha2UKPiB0aGF0 IHNwYWNlIGl0IGZpbmlzaGVzIHRoZSBvbmx5IHJlcXVlc3QgKHNpbmNlIGFsbCAxMDI0IGFyZSBv bmUgYW5kIHRoZQo+IHNhbWUpIHRoZSBjb250aW51ZXMgb253YXJkc2x5IGJsaXRoZWx5IHVuYXdh cmUgaXQganVzdCBsb3N0IHRoZQo+IG9sci9zZXFuby4KPiAKPiBUbyBmaXggdGhpcyByZXF1aXJl cyByZXF1ZXN0IGNyZWF0ZS9jb21taXQgc2VtYW50aWNzLCB3aGVyZSB0aGUgcmVxdWVzdAo+IGNy ZWF0ZSBtYW5hZ2VzIHRoZSBwaW5uaW5nIG9mIHRoZSBjb250ZXh0IGZvciBpdHNlbGYsIGFuZCBh bHNvIGltcG9zZXMKPiB0aGUgbGltaXRhdGlvbiB0aGF0IGEgc2luZ2xlIHJlcXVlc3QgY2Fubm90 IG9jY3VweSB0aGUgZnVsbCByaW5nYnVmZmVyLgo+IC1DaHJpcwoKV2VsbCBJJ2QgdmVyeSBtdWNo IGxpa2UgY3JlYXRlL2NvbW1pdCBzZW1hbnRpY3MsIHNvIHRoYXQgd2UgY2FuIHJvbGwKYmFjayBh bnkgc2VxdWVuY2UgdGhhdCBicmVha3MgcmF0aGVyIHRoYW4gbGVhdmluZyBoYWxmYmFrZWQgY29t bWFuZCBzdHJlYW1zLgoKSSdtIHByZXR0eSBzdXJlIHRoYXQgbm8gc2luZ2xlIHJlcXVlc3QgY2Fu IG9jY3VweSB0aGUgZnVsbCByaW5nYnVmZmVyCnRob3VnaC4gTGFzdCB0aW1lIEkgbWVhc3VyZWQg aXQsIHRoZSBtYXhpbWFsIHNlcXVlbmNlIGZvciBhbnkgc2luZ2xlCnJlcXVlc3Qgd2FzIH4xOTAg RHdvcmRzLCBjb25zaWRlcmFibHkgbGVzcyB0aGFuIDFLYiwgYW5kIG5vdCBlbm91Z2ggdG8KZmls bCBldmVuIHRoZSBzbWFsbCAoNC1wYWdlKSByaW5ncyB1c2VkIHdpdGggR3VDIHN1Ym1pc3Npb24u CgouRGF2ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK