From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4ZJM-0003kh-Gn for qemu-devel@nongnu.org; Mon, 15 Jun 2015 14:40:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4ZJF-0007yo-L8 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 14:40:44 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:54834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4ZJF-0007xw-Ar for qemu-devel@nongnu.org; Mon, 15 Jun 2015 14:40:37 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Jun 2015 19:40:35 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 91496219004D for ; Mon, 15 Jun 2015 19:40:12 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5FIeXbI22347786 for ; Mon, 15 Jun 2015 18:40:33 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5FIeWf6011723 for ; Mon, 15 Jun 2015 12:40:33 -0600 Message-ID: <557F1C1B.1020002@de.ibm.com> Date: Mon, 15 Jun 2015 20:40:27 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1434383829-26451-1-git-send-email-aurelien@aurel32.net> <1434383829-26451-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1434383829-26451-2-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] s390/ioinst: fix IO_INT_WORD_ISC macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Cornelia Huck , Alexander Graf , Richard Henderson Am 15.06.2015 um 17:57 schrieb Aurelien Jarno: > The I/O-Interruption Subclass field corresponds to bits 2 to 5 (BE > notation) of the Interruption-Identification Word. The value should > be shift by 27 instead of 24. > > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Alexander Graf > Signed-off-by: Aurelien Jarno > --- > target-s390x/ioinst.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-s390x/ioinst.h b/target-s390x/ioinst.h > index 203bdba..013cc91 100644 > --- a/target-s390x/ioinst.h > +++ b/target-s390x/ioinst.h > @@ -220,7 +220,7 @@ typedef struct IOIntCode { > #define IOINST_SCHID_SSID(_schid) ((_schid & 0x00060000) >> 17) > #define IOINST_SCHID_NR(_schid) (_schid & 0x0000ffff) > > -#define IO_INT_WORD_ISC(_int_word) ((_int_word & 0x38000000) >> 24) > +#define IO_INT_WORD_ISC(_int_word) ((_int_word & 0x38000000) >> 27) > #define ISC_TO_ISC_BITS(_isc) ((0x80 >> _isc) << 24) > > #define IO_INT_WORD_AI 0x80000000 > Its Connys area of competence, but your change matches the KVM implementation in the kernel static u64 int_word_to_isc_bits(u32 int_word) { u8 isc = (int_word & 0x38000000) >> 27; return (0x80 >> isc) << 24; } so Reviewed-by: Christian Borntraeger