Re: [PATCH] ath9k_htc: introduce support for different fw versions

[Oleksij Rempel <linux@rempel-privat.de>]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Am 15.06.2015 um 01:27 schrieb Julian Calaby:
> Hi Oleksij,
> 
> On Mon, Jun 15, 2015 at 2:12 AM, Oleksij Rempel <linux@rempel-privat.de> wrote:
>> Current kernel support only one fw name with theoretically only one
>> fw version. By replacing fw with other version we will break compatibility
>> with older kernels.
>>
>> To avoid this kind of regression this patch will reuse fw version model
>> from iwlwifi driver.
>>
>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>> ---
>>  drivers/net/wireless/ath/ath9k/hif_usb.c      | 102 ++++++++++++++++++++------
>>  drivers/net/wireless/ath/ath9k/hif_usb.h      |  13 +++-
>>  drivers/net/wireless/ath/ath9k/htc_drv_init.c |   4 +
>>  3 files changed, 95 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
>> index 10c02f5..18407f2 100644
>> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
>> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
>> @@ -17,10 +17,6 @@
>>  #include <asm/unaligned.h>
>>  #include "htc.h"
>>
>> -/* identify firmware images */
>> -#define FIRMWARE_AR7010_1_1     "htc_7010.fw"
>> -#define FIRMWARE_AR9271         "htc_9271.fw"
>> -
>>  MODULE_FIRMWARE(FIRMWARE_AR7010_1_1);
>>  MODULE_FIRMWARE(FIRMWARE_AR9271);
> 
> Shouldn't you declare the versioned firmware names here too?

Thank you.


-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]