All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>,
	linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [RESEND PATCH 0/3] watchdog: MAX63xx cleanup and platform settings
Date: Mon, 15 Jun 2015 14:41:29 -0700	[thread overview]
Message-ID: <557F4689.1050907@roeck-us.net> (raw)
In-Reply-To: <1434398321-16035-1-git-send-email-vivien.didelot@savoirfairelinux.com>

On 06/15/2015 12:58 PM, Vivien Didelot wrote:
> The first version of this patchset from January, 29 [1] got no feedback
> from the maintainer. 1/4 [2] was applied to watchdog-next on May, 30
> though. A concern about constants removal was raised in the preliminary
> 2/4 cleanup patch, the explanation has been added to the related commit
> message.
>

Hi Vivien,

For my part, adding a comment about removal of constants does not alleviate
my concern about removing those constants. I just don't believe that removing
constants is a good idea, no matter what the arguments for doing so might be.

Thanks,
Guenter


  parent reply	other threads:[~2015-06-15 21:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 19:58 [RESEND PATCH 0/3] watchdog: MAX63xx cleanup and platform settings Vivien Didelot
2015-06-15 19:58 ` [RESEND PATCH 1/3] watchdog: max63xx: cleanup Vivien Didelot
2015-06-15 19:58 ` [RESEND PATCH 2/3] watchdog: max63xx: add GPIO support Vivien Didelot
2015-06-15 19:58 ` [RESEND PATCH 3/3] watchdog: max63xx: add heartbeat to platform data Vivien Didelot
2015-06-15 21:41 ` Guenter Roeck [this message]
2015-06-15 23:29   ` [RESEND PATCH 0/3] watchdog: MAX63xx cleanup and platform settings Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557F4689.1050907@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.