From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver Date: Tue, 16 Jun 2015 10:00:30 +0800 Message-ID: <557F833E.9000905@rock-chips.com> References: <1434258820-26779-1-git-send-email-wxt@rock-chips.com> <1434258820-26779-4-git-send-email-wxt@rock-chips.com> <1434380419.2069.38.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1434380419.2069.38.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Paul Bolle Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Peter De Schrijver , ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Stephen Warren , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, Arnd Bergmann , Flora Fu , "jinkun.hong" , Linus Walleij , dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Santosh Shilimkar , Sandeep Nair , Matthias Brugger , Sascha Hauer , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org CgrlnKggMjAxNeW5tDA25pyIMTXml6UgMjM6MDAsIFBhdWwgQm9sbGUg5YaZ6YGTOgo+IE9uIFN1 biwgMjAxNS0wNi0xNCBhdCAxMzoxMyArMDgwMCwgQ2Flc2FyIFdhbmcgd3JvdGU6Cj4KPj4gLS0t IC9kZXYvbnVsbAo+PiArKysgYi9kcml2ZXJzL3NvYy9yb2NrY2hpcC9LY29uZmlnCj4+ICtjb25m aWcgUE1fR0VORVJJQ19ET01BSU5TCj4+ICsgICAgICAgIHRyaXN0YXRlICJSb2NrY2hpcCBnZW5l cmljIHBvd2VyIGRvbWFpbiIKPiBTaW5jZSBteSByZW1hcmtzIG9uIHYxMyB5b3UgcmVtb3ZlZCB0 aGUgbW9kdWxlIHNwZWNpZmljIGNvZGUgZnJvbQo+IHBtX2RvbWFpbnMuYy4gQnV0IG5vdyB0aGlz IGJlY2FtZSBhIHRyaXN0YXRlIHN5bWJvbC4gVGhhdCBtYWtlcyBsaXR0bGUKPiBzZW5zZS4gV2h5 IGRpZG4ndCB5b3Uga2VlcCBib29sPwoKWWVhaCwgeW91IGFyZSByaWdodC4gOnMvdHJpc3RhdGUv Ym9vbAoKSSBmb3JnZXQgaXQgd2hlbiB0aGUgZHJpdmVyIGlzIG1vdmluZyBmcm9tICdhcmNoL2Fy bS9tYWNoLXJvY2tjaGlwLycgdG8gCicvZHJpdmVyL3NvYy9yb2NrY2hpcC8nLgo+Cj4+ICsgICAg ICAgIGRlcGVuZHMgb24gUE0KPj4gKyAgICAgICAgaGVscAo+PiArICAgICAgICAgIFNheSB5IGhl cmUgdG8gZW5hYmxlIHBvd2VyIGRvYW1pbiBzdXBwb3J0Lgo+IHMvZG9hbWluL2RvbWFpbi8uCgpE b25lLgo+PiArICAgICAgICAgIEluIG9yZGVyIHRvIG1lZXQgaGlnaCBwZXJmb3JtYW5jZSBhbmQg bG93IHBvd2VyIHJlcXVpcmVtZW50cywgYSBwb3dlcgo+PiArICAgICAgICAgIG1hbmFnZW1lbnQg dW5pdCBpcyBkZXNpZ25lZCBvciBzYXZpbmcgcG93ZXIgd2hlbiBSSzMyODggaW4gbG93IHBvd2Vy Cj4+ICsgICAgICAgICAgbW9kZS4gVGhlIFJLMzI4OCBQTVUgaXMgZGVkaWNhdGVkIGZvciBtYW5h Z2luZyB0aGUgcG93ZXIgb3QgdGhlIHdob2xlIGNoaXAuCj4gcy9vdC9vZi8KCkRvbmUuCj4+ICsg ICAgICAgICAgSWYgdW5zdXJlLCBzYXkgTi4KPiBUaGFua3MsCj4KPgo+IFBhdWwgQm9sbGUKClRo YW5rcywKCkNhZXNhcgoKPgo+Cj4KCi0tIApUaGFua3MsCi0gQ2Flc2FyCgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: wxt@rock-chips.com (Caesar Wang) Date: Tue, 16 Jun 2015 10:00:30 +0800 Subject: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver In-Reply-To: <1434380419.2069.38.camel@x220> References: <1434258820-26779-1-git-send-email-wxt@rock-chips.com> <1434258820-26779-4-git-send-email-wxt@rock-chips.com> <1434380419.2069.38.camel@x220> Message-ID: <557F833E.9000905@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2015?06?15? 23:00, Paul Bolle ??: > On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote: > >> --- /dev/null >> +++ b/drivers/soc/rockchip/Kconfig >> +config PM_GENERIC_DOMAINS >> + tristate "Rockchip generic power domain" > Since my remarks on v13 you removed the module specific code from > pm_domains.c. But now this became a tristate symbol. That makes little > sense. Why didn't you keep bool? Yeah, you are right. :s/tristate/bool I forget it when the driver is moving from 'arch/arm/mach-rockchip/' to '/driver/soc/rockchip/'. > >> + depends on PM >> + help >> + Say y here to enable power doamin support. > s/doamin/domain/. Done. >> + In order to meet high performance and low power requirements, a power >> + management unit is designed or saving power when RK3288 in low power >> + mode. The RK3288 PMU is dedicated for managing the power ot the whole chip. > s/ot/of/ Done. >> + If unsure, say N. > Thanks, > > > Paul Bolle Thanks, Caesar > > > -- Thanks, - Caesar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbbFPCAv (ORCPT ); Mon, 15 Jun 2015 22:00:51 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:53341 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbbFPCAn (ORCPT ); Mon, 15 Jun 2015 22:00:43 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <19bf82e004394fc89090e775a1e733ec> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <557F833E.9000905@rock-chips.com> Date: Tue, 16 Jun 2015 10:00:30 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle CC: heiko@sntech.de, khilman@linaro.org, tomasz.figa@gmail.com, ulf.hansson@linaro.org, dmitry.torokhov@gmail.com, dianders@chromium.org, linux-rockchip@lists.infradead.org, "jinkun.hong" , Santosh Shilimkar , Linus Walleij , Sascha Hauer , Sandeep Nair , Flora Fu , Arnd Bergmann , Stephen Warren , Matthias Brugger , Peter De Schrijver , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v15 3/4] soc: rockchip: power-domain: add power domain driver References: <1434258820-26779-1-git-send-email-wxt@rock-chips.com> <1434258820-26779-4-git-send-email-wxt@rock-chips.com> <1434380419.2069.38.camel@x220> In-Reply-To: <1434380419.2069.38.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015年06月15日 23:00, Paul Bolle 写道: > On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote: > >> --- /dev/null >> +++ b/drivers/soc/rockchip/Kconfig >> +config PM_GENERIC_DOMAINS >> + tristate "Rockchip generic power domain" > Since my remarks on v13 you removed the module specific code from > pm_domains.c. But now this became a tristate symbol. That makes little > sense. Why didn't you keep bool? Yeah, you are right. :s/tristate/bool I forget it when the driver is moving from 'arch/arm/mach-rockchip/' to '/driver/soc/rockchip/'. > >> + depends on PM >> + help >> + Say y here to enable power doamin support. > s/doamin/domain/. Done. >> + In order to meet high performance and low power requirements, a power >> + management unit is designed or saving power when RK3288 in low power >> + mode. The RK3288 PMU is dedicated for managing the power ot the whole chip. > s/ot/of/ Done. >> + If unsure, say N. > Thanks, > > > Paul Bolle Thanks, Caesar > > > -- Thanks, - Caesar