From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v3][PATCH 10/16] tools: extend xc_assign_device()
 to support rdm reservation policy
Date: Tue, 16 Jun 2015 10:31:29 +0800
Message-ID: <557F8A81.1030701@intel.com>
References: <1433985325-16676-1-git-send-email-tiejun.chen@intel.com>
	<1433985325-16676-11-git-send-email-tiejun.chen@intel.com>
	<20150612154319.GV14606@zion.uk.xensource.com>
	<557E2671.8010206@intel.com>
	<20150615145813.GA10177@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150615145813.GA10177@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, yang.z.zhang@intel.com, Ian.Jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 2015/6/15 22:58, Wei Liu wrote:
> On Mon, Jun 15, 2015 at 09:12:17AM +0800, Chen, Tiejun wrote:
>> On 2015/6/12 23:43, Wei Liu wrote:
>>> On Thu, Jun 11, 2015 at 09:15:19AM +0800, Tiejun Chen wrote:
>>> [...]
>>>>
>>>> -static int next_bdf(char **str, int *seg, int *bus, int *dev, int *func)
>>>> +static int next_bdf(char **str, int *seg, int *bus, int *dev, int *func,
>>>> +                    int *flag)
>>>
>>> This is unrelated change. It should be moved to appropriate patch.
>>>
>>
>> This is in the tools/python/xen/lowlevel/xc/xc.c file,
>>
>> pyxc_assign_device
>>      |
>>      + while ( next_bdf(&pci_str, &seg, &bus, &dev, &func, &flag) )
>> 	|
>> 	+ ...
>> 	|
>> 	+ xc_assign_device()
>>
>> this really should be related to extend xc_assign_device().
>>
>
> Right, this is fine then.
>
> Please write in the commit message that you also adjusted all language
> bindings. Normally when I notice the code doesn't match the commit

I want to add this line into the patch head description,

"Note this also bring some fallout to python usage of xc_assign_device()."

> message I become very skeptical about the code.
>

Sorry for this confusion.

Thanks
Tiejun