From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4j7D-0003Us-Mh for qemu-devel@nongnu.org; Tue, 16 Jun 2015 01:08:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4j79-0008DA-Mk for qemu-devel@nongnu.org; Tue, 16 Jun 2015 01:08:51 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4j76-0008Co-GT for qemu-devel@nongnu.org; Tue, 16 Jun 2015 01:08:46 -0400 Received: by pabqy3 with SMTP id qy3so5179026pab.3 for ; Mon, 15 Jun 2015 22:08:44 -0700 (PDT) Message-ID: <557FAF59.5040601@igel.co.jp> Date: Tue, 16 Jun 2015 14:08:41 +0900 From: Tetsuya Mukawa MIME-Version: 1.0 References: <1432538908-26298-5-git-send-email-mukawa@igel.co.jp> <1432874550-10921-1-git-send-email-mukawa@igel.co.jp> <1432874550-10921-4-git-send-email-mukawa@igel.co.jp> <20150615135859.GE9410@stefanha-thinkpad.redhat.com> In-Reply-To: <20150615135859.GE9410@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 3/4] vhost-user: Enable 'nowait' and 'reconnect' option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: jasowang@redhat.com, qemu-devel@nongnu.org, n.nikolaev@virtualopensystems.com, mst@redhat.com On 2015/06/15 22:58, Stefan Hajnoczi wrote: > On Fri, May 29, 2015 at 01:42:29PM +0900, Tetsuya Mukawa wrote: >> The patch enables 'nowait' option for server mode, and 'reconnect' >> option for client mode. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> net/vhost-user.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/net/vhost-user.c b/net/vhost-user.c >> index 1967ff4..f823d78 100644 >> --- a/net/vhost-user.c >> +++ b/net/vhost-user.c >> @@ -26,6 +26,8 @@ typedef struct VhostUserChardevProps { >> bool is_socket; >> bool is_unix; >> bool is_server; >> + bool is_nowait; >> + bool is_reconnect; >> } VhostUserChardevProps; >> >> VHostNetState *vhost_user_get_vhost_net(NetClientState *nc) >> @@ -178,6 +180,10 @@ static int net_vhost_chardev_opts(const char *name, const char *value, >> props->is_unix = true; >> } else if (strcmp(name, "server") == 0) { >> props->is_server = true; >> + } else if ((strcmp(name, "wait") == 0) && (strcmp(value, "off")) == 0) { >> + props->is_nowait = true; >> + } else if (strcmp(name, "reconnect") == 0) { >> + props->is_reconnect = true; > Where is the code that uses these new options? Above code is only for allowing below QEMU options. -chardev socket,id=chr0,path=/tmp/sock,reconnect=3 -chardev socket,id=chr0,path=/tmp/sock,server,nowait These options are needed, because we don't want to wait for vhost-user backend connection. Regards, Tetsuya