From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4j7r-0004jm-EH for qemu-devel@nongnu.org; Tue, 16 Jun 2015 01:09:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4j7n-0008Ne-8U for qemu-devel@nongnu.org; Tue, 16 Jun 2015 01:09:31 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4j7n-0008NY-25 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 01:09:27 -0400 Received: by padev16 with SMTP id ev16so5262065pad.0 for ; Mon, 15 Jun 2015 22:09:26 -0700 (PDT) Message-ID: <557FAF84.4040507@igel.co.jp> Date: Tue, 16 Jun 2015 14:09:24 +0900 From: Tetsuya Mukawa MIME-Version: 1.0 References: <1432538908-26298-5-git-send-email-mukawa@igel.co.jp> <1432874550-10921-1-git-send-email-mukawa@igel.co.jp> <20150615140838.GF9410@stefanha-thinkpad.redhat.com> In-Reply-To: <20150615140838.GF9410@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/4] Add feature to start QEMU without vhost-user backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: jasowang@redhat.com, qemu-devel@nongnu.org, n.nikolaev@virtualopensystems.com, mst@redhat.com On 2015/06/15 23:08, Stefan Hajnoczi wrote: > On Fri, May 29, 2015 at 01:42:26PM +0900, Tetsuya Mukawa wrote: >> - Change user interface to be able to specify each feature by name. > I disagree with this change, the uint64_t backend_features option was > better because: > > The text options will just result in a very long command-line that is > hard to read for humans. Instead of checking a bit in a single hex > number, you have to scan over long comma-separated text options which > can be in any arbitrary order to find the feature bit you were looking > for. > > This option needs to be scripted or generated by a management tool > anyway since it depends on the vhost-user backend program that is being > paired with QEMU. The number of human users constructing these option > is extremely low - if they use it they'll copy-paste it from their > vhost-user program's documentation so the contents don't matter much > (shorter is better though). > > The text options must be updated when new feature bits are added to > virtio-net. > > For these reasons I find the numeric backend_features option better. Thanks for comments. I guess it's reasonable, so I will revert it in next patches. Regards, Tetsuya