From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: kernel@pengutronix.de,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Thomas Kopp <thomas.kopp@microchip.com>
Subject: Re: [PATCH] can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix endianness conversion
Date: Tue, 21 Jun 2022 08:02:03 +0200 [thread overview]
Message-ID: <557fbf95-a361-be0a-3e8f-42fa1365c9db@prevas.dk> (raw)
In-Reply-To: <20220620144954.895582-1-mkl@pengutronix.de>
On 20/06/2022 16.49, Marc Kleine-Budde wrote:
> In mcp251xfd_register_get_dev_id() the device ID register is read with
> handcrafted SPI transfers. As all registers, this register is in
> little endian, too. However after the transfer the register content is
> converted from big endian to CPU endianness.
>
> Fix the conversion by converting from little endian to CPU endianness.
>
> Side note: So far the register content is 0x0 on all mcp251xfd
> compatible chips, and is only used for an informative printk.
Reviewed-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
next prev parent reply other threads:[~2022-06-21 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 14:49 [PATCH] can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix endianness conversion Marc Kleine-Budde
2022-06-21 6:02 ` Rasmus Villemoes [this message]
2022-06-23 15:02 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557fbf95-a361-be0a-3e8f-42fa1365c9db@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mkl@pengutronix.de \
--cc=thomas.kopp@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.