From: Hartmut Knaack <knaack.h@gmx.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Kevin Tsai <ktsai@capellamicro.com>,
Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: [PATCH 6/7] iio:light:cm3323: make use of GENMASK
Date: Wed, 17 Jun 2015 09:13:40 +0200 [thread overview]
Message-ID: <55811E24.8020902@gmx.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1506170027470.22088@pmeerw.net>
Peter Meerwald schrieb am 17.06.2015 um 00:29:
>
>> Use GENMASK to define the integration time bitmask.
>
> Nack, should be GENMASK(6, 4) I think
Thanks, you are totally right. Seems like I wasn't in the
best shape for coding yesterday. Will fix this and actually
double check this series for other issues.
Thanks,
Hartmut
>
>> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
>> ---
>> drivers/iio/light/cm3323.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
>> index 6bb75e7..4f362d5 100644
>> --- a/drivers/iio/light/cm3323.c
>> +++ b/drivers/iio/light/cm3323.c
>> @@ -29,7 +29,7 @@
>>
>> #define CM3323_CONF_SD_BIT BIT(0) /* sensor disable */
>> #define CM3323_CONF_AF_BIT BIT(1) /* auto/manual force mode */
>> -#define CM3323_CONF_IT_MASK (BIT(4) | BIT(5) | BIT(6))
>> +#define CM3323_CONF_IT_MASK GENMASK(4, 6)
>> #define CM3323_CONF_IT_SHIFT 4
>>
>> #define CM3323_INT_TIME_AVAILABLE "0.04 0.08 0.16 0.32 0.64 1.28"
>>
>
next prev parent reply other threads:[~2015-06-17 7:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 22:16 [PATCH 0/7] cm3323 fixes and cleanups Hartmut Knaack
2015-06-16 22:17 ` [PATCH 1/7] iio:light:cm3323: clear bitmask before set Hartmut Knaack
2015-06-17 7:14 ` Hartmut Knaack
2015-06-16 22:17 ` [PATCH 2/7] iio:light:Kconfig: fix typo in description Hartmut Knaack
2015-06-17 10:05 ` Daniel Baluta
2015-06-16 22:17 ` [PATCH 3/7] iio:light:cm3323: pass up error value Hartmut Knaack
2015-06-17 10:06 ` Daniel Baluta
2015-06-16 22:17 ` [PATCH 4/7] iio:light:cm3323: drop barely used variable Hartmut Knaack
2015-06-17 10:09 ` Daniel Baluta
2015-06-21 13:21 ` Jonathan Cameron
2015-06-16 22:17 ` [PATCH 5/7] iio:light:cm3323: replace unneeded variable Hartmut Knaack
2015-06-17 10:14 ` Daniel Baluta
2015-06-17 22:28 ` Hartmut Knaack
2015-06-16 22:17 ` [PATCH 6/7] iio:light:cm3323: make use of GENMASK Hartmut Knaack
2015-06-16 22:29 ` Peter Meerwald
2015-06-17 7:13 ` Hartmut Knaack [this message]
2015-06-16 22:17 ` [PATCH 7/7] iio:light:cm3323: add empty lines for code structure Hartmut Knaack
2015-06-17 10:17 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55811E24.8020902@gmx.de \
--to=knaack.h@gmx.de \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.