From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z591g-0005La-15 for linux-mtd@lists.infradead.org; Wed, 17 Jun 2015 08:48:53 +0000 Message-ID: <5581345A.5020707@nod.at> Date: Wed, 17 Jun 2015 10:48:26 +0200 From: Richard Weinberger MIME-Version: 1.0 To: Sheng Yong , computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH 1/2] mtd: nandsim: fix free of NULL pointer References: <1434530713-81591-1-git-send-email-shengyong1@huawei.com> <1434530713-81591-2-git-send-email-shengyong1@huawei.com> In-Reply-To: <1434530713-81591-2-git-send-email-shengyong1@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 17.06.2015 um 10:45 schrieb Sheng Yong: > If allocating ns->nand_pages_slab fails, do not try to destroy it when > cleaning up nandsim resources. > > Signed-off-by: Sheng Yong > --- > drivers/mtd/nand/nandsim.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c > index cb38f3d..33e4064 100644 > --- a/drivers/mtd/nand/nandsim.c > +++ b/drivers/mtd/nand/nandsim.c > @@ -646,7 +646,8 @@ static void free_device(struct nandsim *ns) > kmem_cache_free(ns->nand_pages_slab, > ns->pages[i].byte); > } > - kmem_cache_destroy(ns->nand_pages_slab); > + if (ns->nand_pages_slab) > + kmem_cache_destroy(ns->nand_pages_slab); It is perfectly fine to free a NULL pointer. Thanks, //richard