From: Julien Grall <julien.grall@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
Wei Liu <wei.liu2@citrix.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format
Date: Wed, 17 Jun 2015 10:30:39 +0100 [thread overview]
Message-ID: <55813E3F.8030602@citrix.com> (raw)
In-Reply-To: <1434533143.13744.273.camel@citrix.com>
Hi Ian,
On 17/06/2015 10:25, Ian Campbell wrote:
> On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote:
>> Append 0x to all %x in order to avoid while reading when there is other
>> decimal value in the log.
>>
>> Also replace some of the hexadecimal print to decimal to uniformize the
>> format with netfront.
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> Cc: netdev@vger.kernel.org
>
> You meant s/Append/Prepend/, nonetheless:
I noticed a missing word after "avoid" in the commit message too. I will
update to:
"Prepend 0x to all %x in order to avoid confusion while reading when
there is other decimal value in the log.
[...]".
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
I see different opinion on whether using 0x% or %#. As I plan to resend
a version with the commit message update, shall I use %#?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-06-17 9:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 19:10 [PATCH v4 0/3] net/xen: Clean up Julien Grall
2015-06-16 19:10 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-16 19:10 ` Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-21 16:41 ` David Miller
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-21 16:41 ` David Miller
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` Julien Grall
2015-06-16 19:10 ` [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall
2015-06-16 19:10 ` Julien Grall
2015-06-16 20:07 ` Sergei Shtylyov
2015-06-16 22:09 ` Joe Perches
2015-06-16 22:29 ` Sergei Shtylyov
2015-06-16 23:55 ` Joe Perches
2015-06-16 23:55 ` Joe Perches
2015-06-17 8:54 ` Ian Campbell
2015-06-17 8:54 ` Ian Campbell
2015-06-16 22:29 ` Sergei Shtylyov
2015-06-16 22:09 ` Joe Perches
2015-06-16 20:07 ` Sergei Shtylyov
2015-06-17 9:13 ` Jan Beulich
2015-06-17 9:13 ` [Xen-devel] " Jan Beulich
2015-06-17 9:25 ` Ian Campbell
2015-06-17 9:30 ` Julien Grall [this message]
2015-06-17 9:37 ` Ian Campbell
2015-06-17 9:37 ` Ian Campbell
2015-06-17 9:30 ` Julien Grall
2015-06-17 9:25 ` Ian Campbell
2015-06-21 16:41 ` David Miller
2015-06-21 16:41 ` David Miller
2015-06-21 16:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55813E3F.8030602@citrix.com \
--to=julien.grall@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.