From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Wed, 17 Jun 2015 10:46:37 +0000 Subject: Re: [PATCH 1/3] powerpc: implement barrier primitives Message-Id: <5581500D.1060900@suse.de> List-Id: References: <1434534230-17249-1-git-send-email-andre.przywara@arm.com> <1434534230-17249-2-git-send-email-andre.przywara@arm.com> <20150617101506.GD6303@arm.com> In-Reply-To: <20150617101506.GD6303@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Will Deacon , Andre Przywara Cc: "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , Vaidyanathan Srinivasan , Michael Ellerman , Matt Evans On 17.06.15 12:15, Will Deacon wrote: > On Wed, Jun 17, 2015 at 10:43:48AM +0100, Andre Przywara wrote: >> Instead of referring to the Linux header including the barrier >> macros, copy over the rather simple implementation for the PowerPC >> barrier instructions kvmtool uses. This fixes build for powerpc. >> >> Signed-off-by: Andre Przywara >> --- >> Hi, >> >> I just took what kvmtool seems to have used before, I actually have >> no idea if "sync" is the right instruction or "lwsync" would do. >> Would be nice if some people with PowerPC knowledge could comment. > > I *think* we can use lwsync for rmb and wmb, but would want confirmation > from a ppc guy before making that change! Also I'd prefer to play safe for now :) Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 1/3] powerpc: implement barrier primitives Date: Wed, 17 Jun 2015 12:46:37 +0200 Message-ID: <5581500D.1060900@suse.de> References: <1434534230-17249-1-git-send-email-andre.przywara@arm.com> <1434534230-17249-2-git-send-email-andre.przywara@arm.com> <20150617101506.GD6303@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , Vaidyanathan Srinivasan , Michael Ellerman , Matt Evans To: Will Deacon , Andre Przywara Return-path: In-Reply-To: <20150617101506.GD6303@arm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 17.06.15 12:15, Will Deacon wrote: > On Wed, Jun 17, 2015 at 10:43:48AM +0100, Andre Przywara wrote: >> Instead of referring to the Linux header including the barrier >> macros, copy over the rather simple implementation for the PowerPC >> barrier instructions kvmtool uses. This fixes build for powerpc. >> >> Signed-off-by: Andre Przywara >> --- >> Hi, >> >> I just took what kvmtool seems to have used before, I actually have >> no idea if "sync" is the right instruction or "lwsync" would do. >> Would be nice if some people with PowerPC knowledge could comment. > > I *think* we can use lwsync for rmb and wmb, but would want confirmation > from a ppc guy before making that change! Also I'd prefer to play safe for now :) Alex