From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH] slightly simplify SCHEDOP_remote_shutdown
	handling
Date: Wed, 17 Jun 2015 13:59:45 +0100
Message-ID: <55816F41.2040109@eu.citrix.com>
References: <55818A75020000780008621C@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=603259ddc=George.Dunlap@citrix.com>)
	id 1Z5Cwx-0003UZ-3C
	for xen-devel@lists.xenproject.org; Wed, 17 Jun 2015 13:00:15 +0000
In-Reply-To: <55818A75020000780008621C@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 06/17/2015 01:55 PM, Jan Beulich wrote:
> There's no need for two exit paths each using rcu_unlock_domain() on
> its own here.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

> 
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -970,16 +970,10 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN
>              break;
>  
>          ret = xsm_schedop_shutdown(XSM_DM_PRIV, current->domain, d);
> -        if ( ret )
> -        {
> -            rcu_unlock_domain(d);
> -            return ret;
> -        }
> -
> -        domain_shutdown(d, (u8)sched_remote_shutdown.reason);
> +        if ( likely(!ret) )
> +            domain_shutdown(d, sched_remote_shutdown.reason);
>  
>          rcu_unlock_domain(d);
> -        ret = 0;
>  
>          break;
>      }
> 
> 
>